r32949 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32948‎ | r32949 | r32950 >
Date:09:18, 8 April 2008
Author:aaron
Status:old
Tags:
Comment:
Tweak - title index better than user in these cases most likely
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -494,10 +494,10 @@
495495 global $wgAllowLogDeletion;
496496 $log_id = $wgAllowLogDeletion ? 'log_id' : '0 AS log_id';
497497 # Don't use the wrong logging index
498 - if( $this->user ) {
 498+ if( $this->title || $this->pattern ) {
 499+ $index = array( 'USE INDEX' => array( 'logging' => 'page_time' ) );
 500+ } else if( $this->user ) {
499501 $index = array( 'USE INDEX' => array( 'logging' => 'user_time' ) );
500 - } else if( $this->title || $this->pattern ) {
501 - $index = array( 'USE INDEX' => array( 'logging' => 'page_time' ) );
502502 } else if( $this->type ) {
503503 $index = array( 'USE INDEX' => array( 'logging' => 'type_time' ) );
504504 } else {

Status & tagging log