r32875 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32874‎ | r32875 | r32876 >
Date:20:25, 6 April 2008
Author:ialex
Status:old
Tags:
Comment:
(bug 12064) BeforePageDisplay hook is now called for all skins
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -779,6 +779,10 @@
780780 if ($this->mArticleBodyOnly) {
781781 $this->out($this->mBodytext);
782782 } else {
 783+ // Hook that allows last minute changes to the output page, e.g.
 784+ // adding of CSS or Javascript by extensions.
 785+ wfRunHooks( 'BeforePageDisplay', array( &$this ) );
 786+
783787 wfProfileIn( 'Output-skin' );
784788 $sk->outputPage( $this );
785789 wfProfileOut( 'Output-skin' );
Index: trunk/phase3/includes/SkinTemplate.php
@@ -139,10 +139,6 @@
140140 $fname = 'SkinTemplate::outputPage';
141141 wfProfileIn( $fname );
142142
143 - // Hook that allows last minute changes to the output page, e.g.
144 - // adding of CSS or Javascript by extensions.
145 - wfRunHooks( 'BeforePageDisplay', array( &$out ) );
146 -
147143 $oldid = $wgRequest->getVal( 'oldid' );
148144 $diff = $wgRequest->getVal( 'diff' );
149145
Index: trunk/phase3/RELEASE-NOTES
@@ -158,6 +158,7 @@
159159 * (bug 13463) Login successful page doesn't use user's preferred interface language
160160 * (bug 13630) Fixed warnings for pass by reference at call time in
161161 Special:Revisiondelete when generating the log entry.
 162+* (bug 12064) BeforePageDisplay hook is now called for all skins
162163
163164 === API changes in 1.13 ===
164165

Status & tagging log