r32862 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32861‎ | r32862 | r32863 >
Date:17:56, 6 April 2008
Author:ialex
Status:old
Tags:
Comment:
(bug 13630) allow_call_time_pass_reference warnings in Special:Revisiondelete
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialRevisiondelete.php
@@ -1344,7 +1344,7 @@
13451345 * @param int $diff The xor of the old and new bitfields.
13461346 * @param array $arr The array to update.
13471347 */
1348 - function checkItem ( $desc, $field, $diff, $new, $arr ) {
 1348+ function checkItem ( $desc, $field, $diff, $new, &$arr ) {
13491349 if ( $diff & $field ) {
13501350 $arr [ ( $new & $field ) ? 0 : 1 ][] = $desc;
13511351 }
@@ -1366,9 +1366,9 @@
13671367 $diff = $n ^ $o;
13681368 $ret = array ( 0 => array(), 1 => array(), 2 => array() );
13691369
1370 - $this->checkItem ( wfMsgForContent ( 'revdelete-content' ), 1, $diff, $n, &$ret );
1371 - $this->checkItem ( wfMsgForContent ( 'revdelete-summary' ), 2, $diff, $n, &$ret );
1372 - $this->checkItem ( wfMsgForContent ( 'revdelete-uname' ), 4, $diff, $n, &$ret );
 1370+ $this->checkItem ( wfMsgForContent ( 'revdelete-content' ), 1, $diff, $n, $ret );
 1371+ $this->checkItem ( wfMsgForContent ( 'revdelete-summary' ), 2, $diff, $n, $ret );
 1372+ $this->checkItem ( wfMsgForContent ( 'revdelete-uname' ), 4, $diff, $n, $ret );
13731373
13741374 // Restriction application to sysops
13751375 if ( $diff & Revision::DELETED_RESTRICTED ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -156,6 +156,8 @@
157157 * (bug 13431) Show true message source in Special:Allmessages&ot=php / xml
158158 * (bug 13616) Replace underscores in search terms by spaces
159159 * (bug 13463) Login successful page doesn't use user's preferred interface language
 160+* (bug 13630) Fixed warnings for pass by reference at call time in
 161+ Special:Revisiondelete when generating the log entry.
160162
161163 === API changes in 1.13 ===
162164

Status & tagging log