Index: trunk/phase3/includes/SpecialRevisiondelete.php |
— | — | @@ -1344,7 +1344,7 @@ |
1345 | 1345 | * @param int $diff The xor of the old and new bitfields. |
1346 | 1346 | * @param array $arr The array to update. |
1347 | 1347 | */ |
1348 | | - function checkItem ( $desc, $field, $diff, $new, $arr ) { |
| 1348 | + function checkItem ( $desc, $field, $diff, $new, &$arr ) { |
1349 | 1349 | if ( $diff & $field ) { |
1350 | 1350 | $arr [ ( $new & $field ) ? 0 : 1 ][] = $desc; |
1351 | 1351 | } |
— | — | @@ -1366,9 +1366,9 @@ |
1367 | 1367 | $diff = $n ^ $o; |
1368 | 1368 | $ret = array ( 0 => array(), 1 => array(), 2 => array() ); |
1369 | 1369 | |
1370 | | - $this->checkItem ( wfMsgForContent ( 'revdelete-content' ), 1, $diff, $n, &$ret ); |
1371 | | - $this->checkItem ( wfMsgForContent ( 'revdelete-summary' ), 2, $diff, $n, &$ret ); |
1372 | | - $this->checkItem ( wfMsgForContent ( 'revdelete-uname' ), 4, $diff, $n, &$ret ); |
| 1370 | + $this->checkItem ( wfMsgForContent ( 'revdelete-content' ), 1, $diff, $n, $ret ); |
| 1371 | + $this->checkItem ( wfMsgForContent ( 'revdelete-summary' ), 2, $diff, $n, $ret ); |
| 1372 | + $this->checkItem ( wfMsgForContent ( 'revdelete-uname' ), 4, $diff, $n, $ret ); |
1373 | 1373 | |
1374 | 1374 | // Restriction application to sysops |
1375 | 1375 | if ( $diff & Revision::DELETED_RESTRICTED ) { |
Index: trunk/phase3/RELEASE-NOTES |
— | — | @@ -156,6 +156,8 @@ |
157 | 157 | * (bug 13431) Show true message source in Special:Allmessages&ot=php / xml |
158 | 158 | * (bug 13616) Replace underscores in search terms by spaces |
159 | 159 | * (bug 13463) Login successful page doesn't use user's preferred interface language |
| 160 | +* (bug 13630) Fixed warnings for pass by reference at call time in |
| 161 | + Special:Revisiondelete when generating the log entry. |
160 | 162 | |
161 | 163 | === API changes in 1.13 === |
162 | 164 | |