r32848 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32847‎ | r32848 | r32849 >
Date:11:55, 6 April 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* Bug with 0 because of weak typing
Modified paths:
  • /trunk/extensions/CleanChanges/CleanChanges.php (modified) (history)
  • /trunk/extensions/CleanChanges/CleanChanges_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CleanChanges/CleanChanges.php
@@ -11,7 +11,7 @@
1212 /* Extension information */
1313 $wgExtensionCredits['other'][] = array(
1414 'name' => 'Clean Changes',
15 - 'version' => '2008-04-05',
 15+ 'version' => '2008-04-06',
1616 'author' => 'Niklas Laxström',
1717 'descriptionmsg' => 'cleanchanges-desc',
1818 'url' => 'http://www.mediawiki.org/wiki/Extension:CleanChanges',
Index: trunk/extensions/CleanChanges/CleanChanges_body.php
@@ -377,7 +377,7 @@
378378 }
379379
380380 protected function changeInfo( $diff, $hist, $size ) {
381 - if ( $size ) {
 381+ if ( is_int($size) ) {
382382 $size = $this->wrapCharacterDifference( $size );
383383 return "($diff; $hist; $size)";
384384 } else {

Status & tagging log