r32837 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32836‎ | r32837 | r32838 >
Date:06:50, 6 April 2008
Author:amidaniel
Status:old
Tags:
Comment:
Rm FIXME, make brackets consistent with the rest of mw
Modified paths:
  • /trunk/phase3/includes/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialRevisiondelete.php
@@ -1344,8 +1344,7 @@
13451345 * @param int $diff The xor of the old and new bitfields.
13461346 * @param array $arr The array to update.
13471347 */
1348 - function checkItem ( $desc, $field, $diff, $new, $arr )
1349 - {
 1348+ function checkItem ( $desc, $field, $diff, $new, $arr ) {
13501349 if ( $diff & $field ) {
13511350 $arr [ ( $new & $field ) ? 0 : 1 ][] = $desc;
13521351 }
@@ -1363,8 +1362,7 @@
13641363 * @param int $o The old bitfield.
13651364 * @return An array as described above.
13661365 */
1367 - function getChanges ( $n, $o )
1368 - {
 1366+ function getChanges ( $n, $o ) {
13691367 $diff = $n ^ $o;
13701368 $ret = array ( 0 => array(), 1 => array(), 2 => array() );
13711369
@@ -1393,8 +1391,7 @@
13941392 * @param int $obitfield The old bitfield for the revision.
13951393 * @param String $comment The comment associated with the change.
13961394 */
1397 - function getLogMessage ( $count, $nbitfield, $obitfield, $comment )
1398 - {
 1395+ function getLogMessage ( $count, $nbitfield, $obitfield, $comment ) {
13991396 $s = '';
14001397 $changes = $this->getChanges( $nbitfield, $obitfield );
14011398
@@ -1437,7 +1434,6 @@
14381435
14391436 $reason = $this->getLogMessage ( $count, $nbitfield, $obitfield, $comment );
14401437
1441 - // FIXME: do this better
14421438 if( $param=='logid' ) {
14431439 $params = array( implode( ',', $items) );
14441440 $log->addEntry( 'event', $title, $reason, $params );

Status & tagging log