r32820 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32819‎ | r32820 | r32821 >
Date:18:34, 5 April 2008
Author:btongminh
Status:old
Tags:
Comment:
(bug 11633) Explicitly convert redirect titles to strings due to PHP's very weak typing on array keys.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQuery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQuery.php
@@ -275,7 +275,7 @@
276276 $redirValues = array ();
277277 foreach ($pageSet->getRedirectTitles() as $titleStrFrom => $titleStrTo) {
278278 $redirValues[] = array (
279 - 'from' => $titleStrFrom,
 279+ 'from' => strval($titleStrFrom),
280280 'to' => $titleStrTo
281281 );
282282 }
Index: trunk/phase3/RELEASE-NOTES
@@ -191,6 +191,8 @@
192192 * Cleaned up redirect resolution
193193 * Added possibility to obtain all external links through list=exturlusage
194194 * (bug 13606) Added archivename to iiprop
 195+* (bug 11633) Explicitly convert redirect titles to strings due to PHP's
 196+ very weak typing on array keys.
195197
196198 === Languages updated in 1.13 ===
197199

Follow-up revisions

RevisionCommit summaryAuthorDate
r37506Backporting fixes to API that caused it to output plain wrong data:...btongminh14:37, 10 July 2008
r47865API: Some cleanup...catrope16:03, 27 February 2009

Status & tagging log