r32567 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32566‎ | r32567 | r32568 >
Date:16:00, 29 March 2008
Author:minuteelectron
Status:old
Tags:
Comment:
(bug 13554) PHP Notice in old pre-processor when list item is empty. Patch by Cedric Nilly.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Parser_OldPP.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser_OldPP.php
@@ -2146,7 +2146,7 @@
21472147 $inBlockElem = true;
21482148 }
21492149 } else if ( !$inBlockElem && !$this->mInPre ) {
2150 - if ( ' ' == $t{0} and ( $this->mLastSection == 'pre' or trim($t) != '' ) ) {
 2150+ if ( '' != $t and ' ' == $t{0} and ( $this->mLastSection == 'pre' or trim($t) != '' ) ) {
21512151 // pre
21522152 if ($this->mLastSection != 'pre') {
21532153 $paragraphStack = false;
Index: trunk/phase3/RELEASE-NOTES
@@ -141,6 +141,7 @@
142142 * (bug 13532) Use proper timestamp call when reverting images
143143 * (bug 13543) Updated FAQ link in the installer sidebar
144144 * (bug 13540) Date format in confirmation e-mail now matches message language
 145+* (bug 13554) PHP Notice in old pre-processor when list item is empty.
145146
146147
147148 === API changes in 1.13 ===

Status & tagging log