r32563 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32562‎ | r32563 | r32564 >
Date:11:15, 29 March 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* Some organizing
Modified paths:
  • /trunk/extensions/Translate/MessageChecks.php (modified) (history)
  • /trunk/extensions/Translate/TranslateEditAddons.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateEditAddons.php
@@ -116,11 +116,7 @@
117117 $en = $group->getMessage( $key, 'en' );
118118 $xx = $group->getMessage( $key, $code );
119119
120 - // Definition
121120 $boxes = array();
122 - if ( $en !== null ) {
123 - $boxes[] = self::doBox( $en, 'en', wfMsg( self::MSG . 'definition' ) );
124 - }
125121
126122 // In other languages (if any)
127123 $inOtherLanguages = array();
@@ -157,7 +153,7 @@
158154 // Current committed translation
159155 // Should this be higher up, because it's not as importad as definition for example
160156 if ( $xx !== null && $code !== 'en' ) {
161 - $boxes[] = self::dobox( $xx, $code, wfMsg( self::MSG . 'committed' ) );
 157+ //$boxes[] = self::dobox( $xx, $code, wfMsg( self::MSG . 'committed' ) );
162158
163159 // Append translation from the file to edit area, if it's empty.
164160 if ($object->firsttime && $object->textbox1 === '') {
@@ -165,6 +161,12 @@
166162 }
167163 }
168164
 165+ // Definition
 166+ if ( $en !== null ) {
 167+ $boxes[] = self::doBox( $en, 'en', wfMsg( self::MSG . 'definition' ) );
 168+ }
 169+
 170+
169171 // Some syntactic checks
170172 $translation = $object->textbox1 ? $object->textbox1 : $xx;
171173 if ( $translation ) {
Index: trunk/extensions/Translate/MessageChecks.php
@@ -25,23 +25,23 @@
2626 $warnings = array();
2727
2828 if ( count($values = self::checkParameters( $message )) ) {
29 - $warnings[] = wfMsgExt( self::MSG . 'parameters', 'parse', implode( ', ', $values ) );
 29+ $warnings[] = wfMsgExt( self::MSG . 'parameters', 'parseinline', implode( ', ', $values ) );
3030 }
3131
3232 if ( count($values = self::checkBalance( $message )) ) {
33 - $warnings[] = wfMsgExt( self::MSG . 'balance', 'parse', wfEscapeWikiText( implode( ', ', $values ) ) );
 33+ $warnings[] = wfMsgExt( self::MSG . 'balance', 'parseinline', wfEscapeWikiText( implode( ', ', $values ) ) );
3434 }
3535
3636 if ( count($values = self::checkLinks( $message )) ) {
37 - $warnings[] = wfMsgExt( self::MSG . 'links', 'parse', wfEscapeWikiText( implode( ', ', $values ) ) );
 37+ $warnings[] = wfMsgExt( self::MSG . 'links', 'parseinline', wfEscapeWikiText( implode( ', ', $values ) ) );
3838 }
3939
4040 if ( count($values = self::checkXHTML( $message )) ) {
41 - $warnings[] = wfMsgExt( self::MSG . 'xhtml', 'parse', htmlspecialchars( implode( ', ', $values ) ) );
 41+ $warnings[] = wfMsgExt( self::MSG . 'xhtml', 'parseinline', htmlspecialchars( implode( ', ', $values ) ) );
4242 }
4343
4444 if ( self::checkPlural( $message ) ) {
45 - $warnings[] = wfMsgExt( self::MSG . 'plural', 'parse' );
 45+ $warnings[] = wfMsgExt( self::MSG . 'plural', 'parseinline' );
4646 }
4747
4848 return $warnings;

Status & tagging log