r32532 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32531‎ | r32532 | r32533 >
Date:00:48, 28 March 2008
Author:brion
Status:old
Tags:
Comment:
Revert r32525 -- general processing should use TS_MW format consistently.
$db->timestamp() & $db->timestampOrNull() are to be used at the border between general processing and database access.
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -792,15 +792,15 @@
793793 $this->mRealName = $s->user_real_name;
794794 $this->mPassword = $s->user_password;
795795 $this->mNewpassword = $s->user_newpassword;
796 - $this->mNewpassTime = $dbr->timestampOrNull( $s->user_newpass_time );
 796+ $this->mNewpassTime = wfTimestampOrNull( TS_MW, $s->user_newpass_time );
797797 $this->mEmail = $s->user_email;
798798 $this->decodeOptions( $s->user_options );
799 - $this->mTouched = $dbr->timestamp( $s->user_touched );
 799+ $this->mTouched = wfTimestamp(TS_MW,$s->user_touched);
800800 $this->mToken = $s->user_token;
801 - $this->mEmailAuthenticated = $dbr->timestampOrNull( $s->user_email_authenticated );
 801+ $this->mEmailAuthenticated = wfTimestampOrNull( TS_MW, $s->user_email_authenticated );
802802 $this->mEmailToken = $s->user_email_token;
803 - $this->mEmailTokenExpires = $dbr->timestampOrNull( $s->user_email_token_expires );
804 - $this->mRegistration = $dbr->timestampOrNull( $s->user_registration );
 803+ $this->mEmailTokenExpires = wfTimestampOrNull( TS_MW, $s->user_email_token_expires );
 804+ $this->mRegistration = wfTimestampOrNull( TS_MW, $s->user_registration );
805805 $this->mEditCount = $s->user_editcount;
806806 $this->getEditCount(); // revalidation for nulls
807807

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r32525Use database's timestampOrNull(), not the global one, as we're writing the va...greg21:50, 27 March 2008

Status & tagging log