r32526 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32525‎ | r32526 | r32527 >
Date:21:55, 27 March 2008
Author:greg
Status:old
Tags:
Comment:
Wrap timestamp for DB query in $dbr->timestamp() call. Bug 13532.
Modified paths:
  • /trunk/phase3/includes/filerepo/OldLocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/OldLocalFile.php
@@ -168,7 +168,7 @@
169169 if ( is_null( $this->requestedTime ) ) {
170170 $conds['oi_archive_name'] = $this->archive_name;
171171 } else {
172 - $conds[] = 'oi_timestamp <= ' . $dbr->addQuotes( $this->requestedTime );
 172+ $conds[] = 'oi_timestamp <= ' . $dbr->addQuotes( $dbr->timestamp( $this->requestedTime ) );
173173 }
174174 $row = $dbr->selectRow( 'oldimage', $this->getCacheFields( 'oi_' ),
175175 $conds, __METHOD__, array( 'ORDER BY' => 'oi_timestamp DESC' ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r32527Note bug 13532greg21:57, 27 March 2008
r32817* Fixed bug 13532, incorrect use of wfFindFile() causing total breakage of fi...tstarling16:46, 5 April 2008
r33001* (bug 13532) Use proper timestamp call when reverting images...brion00:26, 9 April 2008

Status & tagging log