r32376 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32375‎ | r32376 | r32377 >
Date:18:41, 24 March 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 1600) Strip extra == section markup == in new-comment field
Updated patch by ^demon; previous versions by HappyDog & Alexander
https://bugzilla.wikimedia.org/attachment.cgi?id=4755
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -542,6 +542,9 @@
543543 $this->mMetaData = rtrim( $request->getText( 'metadata' ) );
544544 # Truncate for whole multibyte characters. +5 bytes for ellipsis
545545 $this->summary = $wgLang->truncate( $request->getText( 'wpSummary' ), 250 );
 546+
 547+ # Remove extra headings and whitespace from summaries and new sections.
 548+ $this->summary = trim(preg_replace('/^=+(.*?)=+$/', '$1', trim($this->summary)));
546549
547550 $this->edittime = $request->getVal( 'wpEdittime' );
548551 $this->starttime = $request->getVal( 'wpStarttime' );
Index: trunk/phase3/RELEASE-NOTES
@@ -126,6 +126,7 @@
127127 * (bug 6813) Don't break HTML validator when using trackbacks
128128 * Fix for size checks on SVG images with global 'stroke-width' attribute
129129 * (bug 11874) Inline CSS with !important no longer borken
 130+* (bug 1600) Strip extra == section markup == in new-comment field
130131
131132
132133 === API changes in 1.13 ===

Follow-up revisions

RevisionCommit summaryAuthorDate
r32863Partial revert of r32376: don't strip whitespace from summaries. If you do, ...simetrical17:58, 6 April 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r12058* (bug 1600) Trigger edit conflict on duplicate section=new submissionsvibber12:07, 11 December 2005

Status & tagging log