r32236 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32235‎ | r32236 | r32237 >
Date:18:23, 20 March 2008
Author:btongminh
Status:old
Tags:
Comment:
Missing pages in prop=langlinks and prop=extlinks are now handled properly. (bug 13442)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryExternalLinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLangLinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryLangLinks.php
@@ -40,6 +40,9 @@
4141 }
4242
4343 public function execute() {
 44+ if ( $this->getPageSet()->getGoodTitleCount() == 0 )
 45+ return;
 46+
4447 $this->addFields(array (
4548 'll_from',
4649 'll_lang',
Index: trunk/phase3/includes/api/ApiQueryExternalLinks.php
@@ -40,6 +40,8 @@
4141 }
4242
4343 public function execute() {
 44+ if ( $this->getPageSet()->getGoodTitleCount() == 0 )
 45+ return;
4446
4547 $this->addFields(array (
4648 'el_from',
Index: trunk/phase3/RELEASE-NOTES
@@ -138,6 +138,8 @@
139139 * (bug 13419) Fix gblredirect so it actually works
140140 * (bug 13418) Disable eiredirect because it's useless
141141 * (bug 13395) list=allcategories should use category table
 142+* (bug 13442) Missing pages in prop=langlinks and prop=extlinks are now
 143+ handled properly.
142144
143145 === Languages updated in 1.13 ===
144146

Follow-up revisions

RevisionCommit summaryAuthorDate
r34658Backport API bugfixes from trunk to REL1_12 that caused PHP to spit out fatal...btongminh13:33, 12 May 2008

Status & tagging log