r32234 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32233‎ | r32234 | r32235 >
Date:17:59, 20 March 2008
Author:aaron
Status:old
Tags:
Comment:
Align arrows to top, but move down half a line, so it lines up
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -505,7 +505,7 @@
506506 */
507507 function recentChangesBlockGroup( $block ) {
508508 global $wgLang, $wgContLang, $wgRCShowChangedSize;
509 - $r = '<table cellpadding="0" cellspacing="0" border="0"><tr>';
 509+ $r = '<table cellpadding="0" cellspacing="0" border="0"><tr>';
510510
511511 # Collate list of users
512512 $isnew = false;
@@ -555,7 +555,7 @@
556556 $toggleLink = "javascript:toggleVisibility('$rci','$rcm','$rcl')";
557557 $tl = '<span id="'.$rcm.'"><a href="'.$toggleLink.'">' . $this->sideArrow() . '</a></span>';
558558 $tl .= '<span id="'.$rcl.'" style="display:none"><a href="'.$toggleLink.'">' . $this->downArrow() . '</a></span>';
559 - $r .= '<td valign="middle">'.$tl.'</td>';
 559+ $r .= '<td valign="top">'.$tl.'</td>';
560560
561561 # Main line
562562 $r .= '<td valign="top"><tt>'.$this->recentChangesFlags( $isnew, false, $unpatrolled, '&nbsp;', $bot );
@@ -617,7 +617,7 @@
618618 $r .= "</td></tr></table>\n";
619619
620620 # Sub-entries
621 - $r .= '<div id="'.$rci.'" style="display:none;"><table cellpadding="0" cellspacing="0" border="0">';
 621+ $r .= '<div id="'.$rci.'" style="display:none;"><table cellpadding="0" cellspacing="0" border="0">';
622622 foreach( $block as $rcObj ) {
623623 # Get rc_xxxx variables
624624 // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
@@ -701,7 +701,7 @@
702702 global $wgStylePath;
703703 $encUrl = htmlspecialchars( $wgStylePath . '/common/images/Arr_' . $dir . '.png' );
704704 $encAlt = htmlspecialchars( $alt );
705 - return "<img src=\"$encUrl\" width=\"12\" height=\"12\" alt=\"$encAlt\" />";
 705+ return "<img src=\"$encUrl\" width=\"12\" height=\"12\" style=\"margin-top:.5em;\" alt=\"$encAlt\" />";
706706 }
707707
708708 /**
@@ -765,7 +765,7 @@
766766 extract( $rcObj->mAttribs );
767767 $curIdEq = 'curid='.$rc_cur_id;
768768
769 - $r = '<table cellspacing="0" cellpadding="0" border="0"><tr>';
 769+ $r = '<table cellspacing="0" cellpadding="0" border="0"><tr>';
770770
771771 # spacerArrow() causes issues in FF
772772 $r .= $this->spacerColumn();

Status & tagging log