r32232 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32231‎ | r32232 | r32233 >
Date:17:16, 20 March 2008
Author:brion
Status:old
Tags:
Comment:
Revert r32218 -- incredibly cryptic illegible class names
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -505,7 +505,7 @@
506506 */
507507 function recentChangesBlockGroup( $block ) {
508508 global $wgLang, $wgContLang, $wgRCShowChangedSize;
509 - $r = '<table class="mw-cl-cbg" cellpadding="0" cellspacing="0" border="0"><tr>';
 509+ $r = '<table cellpadding="0" cellspacing="0" border="0"><tr>';
510510
511511 # Collate list of users
512512 $isnew = false;
@@ -617,7 +617,7 @@
618618 $r .= "</td></tr></table>\n";
619619
620620 # Sub-entries
621 - $r .= '<div id="' . $rci . '" style="display:none;"><table class="mw-cl-rci" cellpadding="0" cellspacing="0" border="0">';
 621+ $r .= '<div id="'.$rci.'" style="display:none;"><table cellpadding="0" cellspacing="0" border="0">';
622622 foreach( $block as $rcObj ) {
623623 # Get rc_xxxx variables
624624 // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
@@ -765,7 +765,7 @@
766766 extract( $rcObj->mAttribs );
767767 $curIdEq = 'curid='.$rc_cur_id;
768768
769 - $r = '<table class="mw-cl-cbl" cellspacing="0" cellpadding="0" border="0"><tr>';
 769+ $r = '<table cellspacing="0" cellpadding="0" border="0"><tr>';
770770
771771 # spacerArrow() causes issues in FF
772772 $r .= $this->spacerColumn();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r32218Add a few CSS classes to the tablesraymond11:20, 20 March 2008

Status & tagging log