r32226 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r32225‎ | r32226 | r32227 >
Date:16:49, 20 March 2008
Author:greg
Status:old
Tags:
Comment:
Don't quote the size, it's an int or a literal NULL. Per bug 13453.
Modified paths:
  • /trunk/phase3/maintenance/rebuildrecentchanges.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/rebuildrecentchanges.inc
@@ -103,7 +103,7 @@
104104 $size = $size ? $size : 'NULL';
105105
106106 $sql3 = "UPDATE $recentchanges SET rc_last_oldid=$lastOldId,rc_new=$new,rc_type=$new," .
107 - "rc_old_len='$lastSize',rc_new_len='$size' " .
 107+ "rc_old_len='$lastSize',rc_new_len=$size " .
108108 "WHERE rc_cur_id={$lastCurId} AND rc_this_oldid={$obj->rc_this_oldid}";
109109 $dbw->query( $sql3 );
110110

Follow-up revisions

RevisionCommit summaryAuthorDate
r32227$lastSize is also an int or a literal NULL. Bug 13453.greg16:59, 20 March 2008
r58269(bug 13453) Fix rebuildrecentchanges for DB's with FK constraintsoverlordq18:24, 28 October 2009

Status & tagging log