r32217 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r32216‎ | r32217 | r32218 >
Date:10:46, 20 March 2008
Author:raymond
Status:old
Tags:
Comment:
* (Bug 13448) Fix regression from r32077: Readd CSS id for hidden field.
Please see above bug for a suggestion. I haven't touched upload.js and I am unsure about it. Thanks.
Modified paths:
  • /trunk/phase3/includes/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialUpload.php
——@@ -1181,7 +1181,7 @@
11821182 </td>
11831183 </tr>" .
11841184 Xml::closeElement( 'table' ) .
1185 - Xml::hidden( 'wpDestFileWarningAck', '' ) .
 1185+ Xml::hidden( 'wpDestFileWarningAck', '', array( 'id' => 'wpDestFileWarningAck' ) ) .
11861186 Xml::closeElement( 'fieldset' ) .
11871187 Xml::closeElement( 'form' )
11881188 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r32258bug 13448 second bitbrion21:48, 20 March 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r32077Some rework on 'mainUploadForm':...raymond21:05, 17 March 2008

Status & tagging log