r31911 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r31910‎ | r31911 | r31912 >
Date:12:35, 13 March 2008
Author:raymond
Status:old
Tags:
Comment:
* (bug 13343) Restore default (old name) in Special:MovePage
Fix regression from r31775
Modified paths:
  • /trunk/phase3/includes/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialMovepage.php
@@ -88,7 +88,6 @@
8989 # Show the current title as a default
9090 # when the form is first opened.
9191 $newTitle = $oldTitle;
92 - $encNewTitle = htmlspecialchars( $oldTitle );
9392 } else {
9493 if( $err == '' ) {
9594 $nt = Title::newFromURL( $this->newTitle );
@@ -103,7 +102,6 @@
104103 }
105104 }
106105 $newTitle = $this->newTitle;
107 - $encNewTitle = htmlspecialchars( $newTitle );
108106 }
109107
110108 if ( $err == 'articleexists' && $wgUser->isAllowed( 'delete' ) ) {
@@ -166,7 +164,7 @@
167165 Xml::label( wfMsg( 'newtitle' ), 'wpNewTitle' ) .
168166 "</td>
169167 <td align='$start'>" .
170 - Xml::input( 'wpNewTitle', 40, $this->newTitle, array( 'type' => 'text', 'id' => 'wpNewTitle' ) ) .
 168+ Xml::input( 'wpNewTitle', 40, $newTitle, array( 'type' => 'text', 'id' => 'wpNewTitle' ) ) .
171169 Xml::hidden( 'wpOldTitle', $oldTitle ) .
172170 "</td>
173171 </tr>

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r31775* Add a nice fieldset around the input form...raymond11:06, 11 March 2008

Status & tagging log