r31819 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r31818‎ | r31819 | r31820 >
Date:21:05, 11 March 2008
Author:evan
Status:old
Tags:
Comment:
Some post-release bugs (doh!)
Modified paths:
  • /trunk/extensions/OpenID/SpecialOpenIDConvert.body.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDFinish.body.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDLogin.body.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDServer.body.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDXRDS.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/SpecialOpenIDConvert.body.php
@@ -37,6 +37,8 @@
3838
3939 global $wgRequest, $wgUser, $wgOut;
4040
 41+ $this->setHeaders();
 42+
4143 if ($wgUser->getID() == 0) {
4244 $wgOut->showErrorPage('openiderror', 'notloggedin');
4345 return;
Index: trunk/extensions/OpenID/SpecialOpenIDFinish.body.php
@@ -32,7 +32,7 @@
3333 class SpecialOpenIDFinish extends SpecialOpenID {
3434
3535 function SpecialOpenIDFinish() {
36 - SpecialPage::SpecialPage("OpenIDFinish");
 36+ SpecialPage::SpecialPage("OpenIDFinish", '', false);
3737 self::loadMessages();
3838 }
3939
@@ -40,6 +40,8 @@
4141
4242 global $wgUser, $wgOut, $wgRequest;
4343
 44+ $this->setHeaders();
 45+
4446 # Shouldn't work if you're already logged in.
4547
4648 if ($wgUser->getID() != 0) {
Index: trunk/extensions/OpenID/SpecialOpenIDXRDS.body.php
@@ -31,7 +31,7 @@
3232 class SpecialOpenIDXRDS extends SpecialOpenID {
3333
3434 function SpecialOpenIDXRDS() {
35 - SpecialPage::SpecialPage("OpenIDXRDS");
 35+ SpecialPage::SpecialPage("OpenIDXRDS", '', false);
3636 self::loadMessages();
3737 }
3838
Index: trunk/extensions/OpenID/SpecialOpenIDServer.body.php
@@ -47,7 +47,7 @@
4848 class SpecialOpenIDServer extends SpecialOpenID {
4949
5050 function SpecialOpenIDServer() {
51 - SpecialPage::SpecialPage("OpenIDServer");
 51+ SpecialPage::SpecialPage("OpenIDServer", '', false);
5252 self::loadMessages();
5353 }
5454
@@ -55,6 +55,8 @@
5656
5757 global $wgOut;
5858
 59+ $this->setHeaders();
 60+
5961 $server =& $this->getServer();
6062
6163 switch ($par) {
Index: trunk/extensions/OpenID/SpecialOpenIDLogin.body.php
@@ -37,6 +37,8 @@
3838 function execute($par) {
3939 global $wgRequest, $wgUser, $wgOut;
4040
 41+ $this->setHeaders();
 42+
4143 if ($wgUser->getID() != 0) {
4244 $this->alreadyLoggedIn();
4345 return;

Status & tagging log