r31462 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r31461‎ | r31462 | r31463 >
Date:19:26, 2 March 2008
Author:huji
Status:old
Tags:
Comment:
Partially reverting r31247:
* With that, it was possible to transclude a page in a protected pag with with cascading option selected, thus making the transcluded page protected.. without having protect rights :(
* I'm keeping the editproected permission there in DefaultSettings.php, because it will be used in the "correct" solution to this bug.
* Thanks for ialex for pointing out what I just missed.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1195,7 +1195,7 @@
11961196 foreach( $this->getRestrictions($action) as $right ) {
11971197 // Backwards compatibility, rewrite sysop -> protect
11981198 if ( $right == 'sysop' ) {
1199 - $right = 'editprotected';
 1199+ $right = 'protect';
12001200 }
12011201 if( '' != $right && !$user->isAllowed( $right ) ) {
12021202 $errors[] = array( 'protectedpagetext', $right );
Index: trunk/phase3/RELEASE-NOTES
@@ -21,9 +21,6 @@
2222 === Configuration changes in 1.13 ===
2323
2424 * New option $wgFeed can be set false to turn off syndication feeds
25 -* (bug 13137) Allow setting 'editprotected' right separately from 'protect',
26 - so groups may optionally edit protected pages without being able to protect
27 - pages themselves
2825
2926 === New features in 1.13 ===
3027

Follow-up revisions

RevisionCommit summaryAuthorDate
r32164(bug 13137) Bots to edit protected pages...huji11:23, 19 March 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r31247(bug 13137) Bots to edit protected pageshuji10:36, 25 February 2008

Status & tagging log