r31427 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r31426‎ | r31427 | r31428 >
Date:15:39, 1 March 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* (bug 13207) Patterns containing "--" break page layout
* Fix invalid label for target: reference to non-existent ID "target".
Modified paths:
  • /trunk/extensions/LinkSearch/LinkSearch.php (modified) (history)
  • /trunk/extensions/LinkSearch/LinkSearch_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LinkSearch/LinkSearch_body.php
@@ -50,8 +50,7 @@
5151 Xml::hidden( 'title', $self->getPrefixedDbKey() ) .
5252 '<fieldset>' .
5353 Xml::element( 'legend', array(), wfMsg( 'linksearch' ) ) .
54 - Xml::label( wfMsg( 'linksearch-pat' ), 'target' ) . ' ' .
55 - Xml::input( 'target', 50 , $target ) . ' ';
 54+ Xml::inputLabel( wfMsg( 'linksearch-pat' ), 'target', 'target', 50, $target ) . ' ';
5655 if ( !$wgMiserMode ) {
5756 $s .= Xml::label( wfMsg( 'linksearch-ns' ), 'namespace' ) . ' ' .
5857 XML::namespaceSelector( $namespace, '' );
@@ -76,8 +75,8 @@
7776 $this->mProt = $prot;
7877 }
7978
80 - function getName() {
81 - return 'Linksearch';
 79+ function getName() {
 80+ return 'Linksearch';
8281 }
8382
8483 /**
@@ -156,7 +155,8 @@
157156 $wgOut->addWikiText( wfMsg( 'linksearch-error' ) );
158157 } else {
159158 // For debugging
160 - $wgOut->addHtml( "\n<!-- " . htmlspecialchars( $this->mMungedQuery ) . " -->\n" );
 159+ // Generates invalid xhtml with patterns that contain --
 160+ //$wgOut->addHtml( "\n<!-- " . htmlspecialchars( $this->mMungedQuery ) . " -->\n" );
161161 parent::doQuery( $offset, $limit, $shownavigation );
162162 }
163163 }
Index: trunk/extensions/LinkSearch/LinkSearch.php
@@ -12,7 +12,7 @@
1313 'description' => 'Find pages with external links matching specific patterns',
1414 'descriptionmsg' => 'linksearch-desc',
1515 'url' => 'http://www.mediawiki.org/wiki/Extension:LinkSearch',
16 - 'version' => '1.2',
 16+ 'version' => '1.3',
1717 );
1818
1919 $wgExtensionMessagesFiles['LinkSearch'] = dirname(__FILE__) . '/LinkSearch.i18n.php';

Status & tagging log