r31330 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r31329‎ | r31330 | r31331 >
Date:22:47, 26 February 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 13086) Trackbacks were returning invalid XML (extra whitespace)
Modified paths:
  • /trunk/phase3/trackback.php (modified) (history)

Diff [purge]

Index: trunk/phase3/trackback.php
@@ -11,8 +11,7 @@
1212 */
1313 function XMLsuccess() {
1414 header("Content-Type: application/xml; charset=utf-8");
15 - echo "
16 -<?xml version=\"1.0\" encoding=\"utf-8\"?>
 15+ echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>
1716 <response>
1817 <error>0</error>
1918 </response>
@@ -23,8 +22,7 @@
2423 function XMLerror($err = "Invalid request.") {
2524 header("HTTP/1.0 400 Bad Request");
2625 header("Content-Type: application/xml; charset=utf-8");
27 - echo "
28 -<?xml version=\"1.0\" encoding=\"utf-8\"?>
 26+ echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>
2927 <response>
3028 <error>1</error>
3129 <message>Invalid request: $err</message>

Follow-up revisions

RevisionCommit summaryAuthorDate
r31331Merge fixes from trunk:...brion22:53, 26 February 2008

Status & tagging log