r30827 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r30826‎ | r30827 | r30828 >
Date:08:57, 11 February 2008
Author:huji
Status:old
Tags:
Comment:
Allows findhooks to find these hooks:
* FileUpload
* LanguageGetMagic
* LanguageGetSpecialPageAliases
* MonoBookTemplateToolboxEnd
Regardless, these hooks are still not found (although they are in use by extensions):
* LoadExtensionSchemaUpdates
* ParserTestParser
* ParserTestTables
Modified paths:
  • /trunk/phase3/maintenance/findhooks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/findhooks.php
@@ -24,6 +24,9 @@
2525
2626 $doc = $IP . '/docs/hooks.txt';
2727 $pathinc = $IP . '/includes/';
 28+$pathfile = $IP . '/includes/filerepo/LocalFile.php';
 29+$pathlang = $IP . '/languages/Language.php';
 30+$pathskin = $IP . '/skins/MonoBook.php';
2831
2932
3033 # FUNCTIONS
@@ -115,9 +118,20 @@
116119 # MAIN
117120
118121 $documented = getHooksFromDoc($doc);
119 -$potential = getHooksFromPath($pathinc);
120 -$bad = getBadHooksFromPath($pathinc);
121122
 123+$potenial_inc = getHooksFromPath($pathinc);
 124+$potential_file = getHooksFromFile($pathfile);
 125+$potential_lang = getHooksFromFile($pathlang);
 126+$potential_skin = getHooksFromFile($pathskin);
 127+
 128+$bad_inc = getBadHooksFromPath($pathinc);
 129+$bad_file = getBadHooksFromFile($pathfile);
 130+$bad_lang = getBadHooksFromFile($pathlang);
 131+$bad_skin = getBadHooksFromFile($pathskin);
 132+
 133+$potential = array_merge($potenial_inc, $potential_file, $potential_lang, $potential_skin);
 134+$bad = array_merge($bad_inc, $bad_file, $bad_lang, $bad_skin);
 135+
122136 $todo = array_diff($potential, $documented);
123137 $deprecated = array_diff($documented, $potential);
124138

Status & tagging log