r30803 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r30802‎ | r30803 | r30804 >
Date:17:37, 10 February 2008
Author:tlaqua
Status:old
Tags:
Comment:
* Fixed check for self deletion
Modified paths:
  • /trunk/extensions/UserMerge/UserMerge.php (modified) (history)
  • /trunk/extensions/UserMerge/UserMerge_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UserMerge/UserMerge_body.php
@@ -58,7 +58,7 @@
5959 } elseif ( in_array( $olduserID, $wgUserMergeUnmergeable ) || in_array( $olduser_text, $wgUserMergeUnmergeable ) ) {
6060 $validOldUser = false;
6161 $wgOut->addHTML( "<span style=\"color: red;\">" . wfMsg('usermerge-unmergable') . "</span><br>\n" );
62 - } elseif ( $objOldUser = $wgUser->getID() ) {
 62+ } elseif ( $olduserID == $wgUser->getID() ) {
6363 $validOldUser = false;
6464 $wgOut->addHTML( "<span style=\"color: red;\">" . wfMsg('usermerge-noselfdelete') . "</span><br>\n" );
6565 } else {
Index: trunk/extensions/UserMerge/UserMerge.php
@@ -16,7 +16,7 @@
1717 'author' => 'Tim Laqua',
1818 'description' => "Merges references from one user to another user in the Wiki database - will also delete old users following merge. Requires 'usermerge' privileges.",
1919 'descriptionmsg' => 'usermerge-desc',
20 - 'version' => '1.4.1'
 20+ 'version' => '1.4.2'
2121 );
2222
2323 $dir = dirname(__FILE__) . '/';

Status & tagging log