r30605 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r30604‎ | r30605 | r30606 >
Date:05:50, 6 February 2008
Author:raymond
Status:old
Tags:
Comment:
* (bug 12931) Fix wrong global variable in SpecialVersion
* Housekeeping RELEASE-NOTES: max line lenghts 80 chars.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialVersion.php
@@ -91,9 +91,9 @@
9292
9393 /** Generate wikitext showing extensions name, URL, author and description */
9494 function extensionCredits() {
95 - global $wgExtensionCredits, $wgExtensionFunctions, $wgParser, $wgSkinExtensionFunction;
 95+ global $wgExtensionCredits, $wgExtensionFunctions, $wgParser, $wgSkinExtensionFunctions;
9696
97 - if ( ! count( $wgExtensionCredits ) && ! count( $wgExtensionFunctions ) && ! count( $wgSkinExtensionFunction ) )
 97+ if ( ! count( $wgExtensionCredits ) && ! count( $wgExtensionFunctions ) && ! count( $wgSkinExtensionFunctions ) )
9898 return '';
9999
100100 $extensionTypes = array(
@@ -144,9 +144,9 @@
145145 $out .= '<tr><td colspan="3">' . $this->listToText( $fhooks ) . "</td></tr>\n";
146146 }
147147
148 - if ( count( $wgSkinExtensionFunction ) ) {
 148+ if ( count( $wgSkinExtensionFunctions ) ) {
149149 $out .= $this->openExtType( wfMsg( 'version-skin-extension-functions' ) );
150 - $out .= '<tr><td colspan="3">' . $this->listToText( $wgSkinExtensionFunction ) . "</td></tr>\n";
 150+ $out .= '<tr><td colspan="3">' . $this->listToText( $wgSkinExtensionFunctions ) . "</td></tr>\n";
151151 }
152152 $out .= Xml::closeElement( 'table' );
153153 return $out;
Index: trunk/phase3/RELEASE-NOTES
@@ -305,7 +305,8 @@
306306 user-customized ones (like Common.css, Common.js)
307307 * (bug 12283) Special:Newpages forgets parameters
308308 * (bug 12031) All namespaces doesn't work in Special:Newpages
309 -* (bug 585) Only create searchindex replica table for parser tests if db is MySQL
 309+* (bug 585) Only create searchindex replica table for parser tests if db is
 310+ MySQL
310311 * Allow --record option if parserTests.php to work when using Postgres
311312 * (bug 12296) Simplify cache epoch in default LocalSettings.php
312313 * (bug 12346) XML fix when body double-click and click handlers are present
@@ -352,11 +353,13 @@
353354 * Security fix for API on MSIE
354355 * (bug 12768) Database query syntax error in maintenance/storage/compressOld.inc
355356 * (bug 12753) Empty captions in MediaWiki:Sidebar result in PHP errors
356 -* (bug 12790) Page protection is not logged when edit-protection is used and move-protection is not
 357+* (bug 12790) Page protection is not logged when edit-protection is used
 358+ and move-protection is not
357359 * (bug 12793) Fix for restricted namespaces/pages in Special:Export
358360 * Fix for Special:Export so it doesn't ignore the page named '0'
359361 * Don't display rollback link if the user doesn't have all required permissions
360 -* The comment of a time-limited protection now contains the date in the default format
 362+* The comment of a time-limited protection now contains the date in the default
 363+ format
361364 * (bug 12880) wfLoadExtensionMessages does not use $fallback from MessagesXx.php
362365 * (bug 12885) Correction for Russian convertPlural function
363366 * (bug 12768) Make DatabasePostgres->hasContraint() schema aware.
@@ -364,6 +367,7 @@
365368 * (bug 12892) Poor tab indexing on "delete file" form
366369 * (bug 12660) When creating an account by e-mail, do not send the creator's IP
367370 address
 371+* (bug 12931) Fix wrong global variable in SpecialVersion
368372
369373 == Parser changes in 1.12 ==
370374
@@ -469,14 +473,16 @@
470474 * Make prop=info check for restrictions in the old format too.
471475 * Add apihighlimits permission, default for sysops and bots
472476 * Add limit=max to use maximal limit
473 -* Add action=parse to render parser output. Use it instead of action=render which has been removed
 477+* Add action=parse to render parser output. Use it instead of action=render
 478+ which has been removed
474479 * Add rvtoken=rollback to prop=revisions
475480 * Add meta=allmessages to get messages from site's messages cache.
476481 * Use bold and italics highlighting only in API help
477 -* Added action={block,delete,move,protect,rollback,unblock,undelete} and list={blocks,deletedrevs}
 482+* Added action={block,delete,move,protect,rollback,unblock,undelete} and
 483+ list={blocks,deletedrevs}
478484 * Fixed sessionid attribute in action=login
479 -* Standardized limits. Revisions and Deletedrevisions formerly using 200 / 10000,
480 - now 500 / 5000, in line with other modules.
 485+* Standardized limits. Revisions and Deletedrevisions formerly using
 486+ 200 / 10000, now 500 / 5000, in line with other modules.
481487 * Added list=allcategories module
482488 * (bug 12321) API list=blocks reveals private data
483489 * Fix output of wfSajaxSearch
@@ -484,13 +490,18 @@
485491 * Add list of sections to action=parse output
486492 * Added action=logout
487493 * Added cascade flag to prop=info&inprop=protections
488 -* Added wlshow parameter to list=watchlist, similar to rcshow (list=recentchanges)
 494+* Added wlshow parameter to list=watchlist, similar to rcshow
 495+ (list=recentchanges)
489496 * Added support for image thumbnailing to prop=imageinfo
490 -* action={login,block,delete,move,protect,rollback,unblock,undelete} now must be POSTed
491 -* prop=imageinfo interface changed: iihistory replaced by iilimit, iistart and iiend parameters
 497+* action={login,block,delete,move,protect,rollback,unblock,undelete} now must be
 498+ POSTed
 499+* prop=imageinfo interface changed: iihistory replaced by iilimit, iistart and
 500+ iiend parameters
492501 * Added amlang parameter to meta=allmessages
493 -* Added apfilterlanglinks parameter to list=allpages, replacing query.php?what=nolanglinks
494 -* (bug 12718) Added action=paraminfo module that provides information about API modules and their parameters
 502+* Added apfilterlanglinks parameter to list=allpages, replacing
 503+ query.php?what=nolanglinks
 504+* (bug 12718) Added action=paraminfo module that provides information about API
 505+ modules and their parameters
495506 * Added iiurlwidth and iiurlheight parameters to prop=imageinfo
496507 * Added format=txt and format=dbg, imported from query.php
497508 * Added uiprop=editcount to meta=userinfo

Status & tagging log