r30351 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r30350‎ | r30351 | r30352 >
Date:16:29, 31 January 2008
Author:raymond
Status:old
Tags:
Comment:
Tweak for r30349: Use existing message 'and' instead of introducing a new one. Thanks to SPQRobin :)
Message 'and' moved to a more general section in maintenance/language/messages.inc
Modified paths:
  • /trunk/phase3/includes/SpecialVersion.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -142,6 +142,7 @@
143143 'mytalk',
144144 'anontalk',
145145 'navigation',
 146+ 'and',
146147 ),
147148 'metadata_help' => array(
148149 'metadata_help',
@@ -1723,7 +1724,6 @@
17241725 'anonymous',
17251726 'siteuser',
17261727 'lastmodifiedatby',
1727 - 'and',
17281728 'othercontribs',
17291729 'others',
17301730 'siteusers',
Index: trunk/phase3/includes/SpecialVersion.php
@@ -256,7 +256,7 @@
257257 $t = array_slice( $list, 0, $cnt - 1 );
258258 $one = array_map( array( &$this, 'arrayToString' ), $t );
259259 $two = $this->arrayToString( $list[$cnt - 1] );
260 - $and = wfMsg( 'version-and' );
 260+ $and = wfMsg( 'and' );
261261
262262 return implode( ', ', $one ) . " $and $two";
263263 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -593,6 +593,7 @@
594594 'mytalk' => 'My talk',
595595 'anontalk' => 'Talk for this IP',
596596 'navigation' => 'Navigation',
 597+'and' => 'and',
597598
598599 # Metadata in edit box
599600 'metadata_help' => 'Metadata:',
@@ -2470,7 +2471,6 @@
24712472 'anonymous' => 'Anonymous user(s) of {{SITENAME}}',
24722473 'siteuser' => '{{SITENAME}} user $1',
24732474 'lastmodifiedatby' => 'This page was last modified $2, $1 by $3.', # $1 date, $2 time, $3 user
2474 -'and' => 'and',
24752475 'othercontribs' => 'Based on work by $1.',
24762476 'others' => 'others',
24772477 'siteusers' => '{{SITENAME}} user(s) $1',
@@ -3149,6 +3149,5 @@
31503150 'version-skin-extension-functions' => 'Skin extension functions',
31513151 'version-hook-name' => 'Hook name',
31523152 'version-hook-subscribedby' => 'Subscribed by',
3153 -'version-and' => 'and',
31543153 'version-version' => 'Version',
31553154 );
Index: trunk/phase3/languages/messages/MessagesDe.php
@@ -307,6 +307,7 @@
308308 'mytalk' => 'Eigene Diskussion',
309309 'anontalk' => 'Diskussionsseite dieser IP',
310310 'navigation' => 'Navigation',
 311+'and' => 'und',
311312
312313 # Metadata in edit box
313314 'metadata_help' => 'Metadaten:',
@@ -1988,7 +1989,6 @@
19891990 'anonymous' => 'Anonyme(r) Benutzer auf {{SITENAME}}',
19901991 'siteuser' => '{{SITENAME}}-Benutzer $1',
19911992 'lastmodifiedatby' => 'Diese Seite wurde zuletzt am $1 um $2 Uhr von $3 geändert.', # $1 date, $2 time, $3 user
1992 -'and' => 'und',
19931993 'othercontribs' => 'Basiert auf der Arbeit von $1',
19941994 'others' => 'andere',
19951995 'siteusers' => '{{SITENAME}}-Benutzer $1',
@@ -2496,6 +2496,5 @@
24972497 'version-skin-extension-functions' => 'Skin-Erweiterungs-Funktionen',
24982498 'version-hook-name' => 'Schnittstellenname',
24992499 'version-hook-subscribedby' => 'Aufruf von',
2500 -'version-and' => 'und',
25012500 'version-version' => 'Version',
25022501 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r30349* (bug 10365) Localization of Special:Version...raymond14:38, 31 January 2008

Status & tagging log