r30274 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r30273‎ | r30274 | r30275 >
Date:01:06, 30 January 2008
Author:brion
Status:old
Tags:
Comment:
put a @ on a chmod, since all other file ops in there are so marked.
redundant chmods can bring warnings if we don't own the file (even though it's already world-writable)
Modified paths:
  • /trunk/phase3/includes/filerepo/FSRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/FSRepo.php
——@@ -422,7 +422,7 @@
423423 $status->error( 'filerenameerror', $srcPath, $archivePath );
424424 $good = false;
425425 } else {
426 - chmod( $archivePath, 0644 );
 426+ @chmod( $archivePath, 0644 );
427427 }
428428 }
429429 if ( $good ) {

Status & tagging log