r30270 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r30269‎ | r30270 | r30271 >
Date:20:23, 29 January 2008
Author:brion
Status:old
Tags:
Comment:
Cleanup -- fix broken XHTML in deletion forms
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/FileDeleteForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -2096,7 +2096,7 @@
20972097 Xml::element( 'legend', array(), wfMsg( 'delete-legend' ) ) .
20982098 Xml::openElement( 'table' ) .
20992099 "<tr id=\"wpDeleteReasonListRow\" name=\"wpDeleteReasonListRow\">
2100 - <td align=$align>" .
 2100+ <td align='$align'>" .
21012101 Xml::label( wfMsg( 'deletecomment' ), 'wpDeleteReasonList' ) .
21022102 "</td>
21032103 <td>" .
@@ -2106,7 +2106,7 @@
21072107 "</td>
21082108 </tr>
21092109 <tr id=\"wpDeleteReasonRow\" name=\"wpDeleteReasonRow\">
2110 - <td align=$align>" .
 2110+ <td align='$align'>" .
21112111 Xml::label( wfMsg( 'deleteotherreason' ), 'wpReason' ) .
21122112 "</td>
21132113 <td>" .
@@ -2128,7 +2128,6 @@
21292129 Xml::closeElement( 'table' ) .
21302130 Xml::closeElement( 'fieldset' ) .
21312131 Xml::hidden( 'wpEditToken', $wgUser->editToken() ) .
2132 - Xml::closeElement( 'fieldset' ) .
21332132 Xml::closeElement( 'form' );
21342133
21352134 $wgOut->addHTML( $form );
Index: trunk/phase3/includes/FileDeleteForm.php
@@ -120,7 +120,7 @@
121121 $this->prepareMessage( 'filedelete-intro' ) .
122122 Xml::openElement( 'table' ) .
123123 "<tr>
124 - <td align=$align>" .
 124+ <td align='$align'>" .
125125 Xml::label( wfMsg( 'filedelete-comment' ), 'wpDeleteReasonList' ) .
126126 "</td>
127127 <td>" .
@@ -130,7 +130,7 @@
131131 "</td>
132132 </tr>
133133 <tr>
134 - <td align=$align>" .
 134+ <td align='$align'>" .
135135 Xml::label( wfMsg( 'filedelete-otherreason' ), 'wpReason' ) .
136136 "</td>
137137 <td>" .

Status & tagging log