r30115 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r30114‎ | r30115 | r30116 >
Date:12:52, 24 January 2008
Author:huji
Status:old
Tags:
Comment:
(bug 12753) Empty captions in MediaWiki:Sidebar result in PHP errors
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1626,6 +1626,7 @@
16271627 if (strpos($line, '**') !== 0) {
16281628 $line = trim($line, '* ');
16291629 $heading = $line;
 1630+ if( strlen($heading) == 0) $heading='';
16301631 } else {
16311632 if (strpos($line, '|') !== false) { // sanity check
16321633 $line = explode( '|' , trim($line, '* '), 2 );
Index: trunk/phase3/RELEASE-NOTES
@@ -336,6 +336,7 @@
337337 * (bug 6436) Localization of Special:Import XML parser Error message(s).
338338 * Security fix for API on MSIE
339339 * (bug 12768) Database query syntax error in maintenance/storage/compressOld.inc
 340+* (bug 12753) Empty captions in MediaWiki:Sidebar result in PHP errors
340341
341342 == Parser changes in 1.12 ==
342343

Follow-up revisions

RevisionCommit summaryAuthorDate
r30125(bug 12753) Empty captions in MediaWiki:Sidebar result in PHP errors....huji17:06, 24 January 2008

Status & tagging log