r3009 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r3008‎ | r3009 | r3010 >
Date:14:37, 7 April 2004
Author:gabrielwicke
Status:old
Tags:
Comment:
reordered navi links, new talk is structure (no escaping applied with structure keyword)
Modified paths:
  • /trunk/phase3/templates/xhtml_slim.pt (modified) (history)

Diff [purge]

Index: trunk/phase3/templates/xhtml_slim.pt
@@ -35,7 +35,7 @@
3636 <h3 id="siteSubtitle" i18n:translate="string:fromwikipedia">From Wikipedia, the free encyclopedia.</h3>
3737 <div tal:condition="subtitle" id="documentSubtitle" tal:content="structure subtitle"></div>
3838 <!-- <esi:include src="userxy/message"/> cached per user, purged on new message-->
39 - <div tal:condition="newtalk" class="portalMessage" tal:content="newtalk"></div>
 39+ <div tal:condition="newtalk" class="portalMessage" tal:content="structure newtalk"></div>
4040 <!-- the content area is cached with the remaining inexpensive sceleton, one version for all.
4141 The edit links and right-click section stuff can be attached from js -->
4242 <!-- start content -->
@@ -57,7 +57,7 @@
5858 <ul>
5959 <li tal:repeat="action content_actions"
6060 tal:attributes="id string:contentaction-${repeat/action/key}; class action/class|default"><a
61 - tal:attributes="title action/ttip|default; accesskey action/akey|default;href action/href|default"
 61+ tal:attributes="title action/ttip|default;accesskey action/akey|default;href action/href|default"
6262 tal:content="action/text">Linktext</a></li>
6363 </ul>
6464 </div>
@@ -87,12 +87,18 @@
8888 <li><a href="${nav_urls/mainpage/href}"
8989 i18n:attributes="accesskey string:accesskey-mainpage | default; title string:tooltip-mainpage"
9090 i18n:translate="string:mainpage">Main Page</a></li>
 91+ <li tal:condition="nav_urls/portal/href"><a href="${nav_urls/portal/href}"
 92+ i18n:attributes="accesskey string:accesskey-portal | default; title string:tooltip-portal|default"
 93+ i18n:translate="string:portal">Community Portal</a></li>
 94+ <li tal:condition="nav_urls/currentevents/href"><a href="${nav_urls/currentevents/href}"
 95+ i18n:attributes="title string:tooltip-currentevents|default"
 96+ i18n:translate="string:currentevents">Current Events</a></li>
9197 <li><a href="${nav_urls/randompage/href}"
9298 i18n:attributes="accesskey string:accesskey-randompage | default; title string:tooltip-randompage"
9399 i18n:translate="string:randompage">Random Page</a></li>
94 - <li tal:condition="${nav_urls/currentevents/href}"><a href="${nav_urls/currentevents/href}"
95 - i18n:attributes="title string:tooltip-currentevents|default"
96 - i18n:translate="string:currentevents">Current Events</a></li>
 100+ <li><a href="${nav_urls/help/href}"
 101+ i18n:attributes="title string:tooltip-help|default"
 102+ i18n:translate="string:help">Help</a></li>
97103 <li><a href="${nav_urls/sitesupport/href}"
98104 i18n:attributes="title string:tooltip-sitesupport|default"
99105 i18n:translate="string:sitesupport">Donations</a></li>
@@ -122,18 +128,15 @@
123129 <div class="portletBody">
124130 <div class="portletContent odd">
125131 <ul>
126 - <li><a href="${nav_urls/help/href}"
127 - i18n:attributes="title string:tooltip-help|default"
128 - i18n:translate="string:help">Help</a></li>
129132 <li><a href="${nav_urls/recentchanges/href}"
130133 i18n:attributes="accesskey string:accesskey-recentchanges|default; title string:tooltip-recentchanges|default"
131134 i18n:translate="string:recentchanges">Recent Changes</a></li>
 135+ <li><a href="${nav_urls/whatlinkshere/href}"
 136+ i18n:attributes="accesskey string:accesskey-whatlinkshere|default; title string:tooltip-whatlinkshere|default"
 137+ i18n:translate="string:whatlinkshere">What links here</a></li>
132138 <li><a href="${nav_urls/recentchangeslinked/href}"
133139 i18n:attributes="title string:tooltip-recentchangeslinked | default"
134140 i18n:translate="string:recentchangeslinked">Related Changes</a></li>
135 - <li><a href="${nav_urls/whatlinkshere/href}"
136 - i18n:attributes="accesskey string:accesskey-whatlinkshere|default; title string:tooltip-whatlinkshere|default"
137 - i18n:translate="string:whatlinkshere">What links here</a></li>
138141 <li><a href="${nav_urls/specialpages/href}"
139142 i18n:attributes="title string:tooltip-specialpages|default"
140143 i18n:translate="string:specialpages">Special Pages</a></li>

Status & tagging log