r29956 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29955‎ | r29956 | r29957 >
Date:19:38, 19 January 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* Right amount of quoting
Modified paths:
  • /trunk/extensions/Translate/Exporters.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/Exporters.php
@@ -87,7 +87,7 @@
8888
8989 $headerP = "
9090 .*? # Ungreedily eat header
91 - \$$var \s* = \s* array\(\);";
 91+ \\$$var \s* = \s* array\(\);";
9292 /*
9393 * x to have nice syntax
9494 * u for utf-8
@@ -103,7 +103,7 @@
104104 list( , $header, $data) = $matches;
105105
106106 $sectionP = '(?: /\*\* .*? \*/ )? (?: ( [^\n]*? \S;\n ) | (?: .*? \n\);\n\n ) )';
107 - $codeP = "\$$var\[' (.*?) '\]";
 107+ $codeP = "\\$$var\[' (.*?) '\]";
108108
109109 $sectionMatches = array();
110110 if ( !preg_match_all( "~$sectionP~xsu", $data, $sectionMatches, PREG_SET_ORDER ) ) {

Status & tagging log