r29946 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29945‎ | r29946 | r29947 >
Date:10:27, 19 January 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* Xml::
Modified paths:
  • /trunk/phase3/includes/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialVersion.php
@@ -102,7 +102,7 @@
103103 wfRunHooks( 'SpecialVersionExtensionTypes', array( &$this, &$extensionTypes ) );
104104
105105 $out = "<h2>Extensions</h2>\n";
106 - $out .= wfOpenElement('table', array('id' => 'sv-ext') );
 106+ $out .= Xml::openElement('table', array('id' => 'sv-ext') );
107107
108108 foreach ( $extensionTypes as $type => $text ) {
109109 if ( isset ( $wgExtensionCredits[$type] ) && count ( $wgExtensionCredits[$type] ) ) {
@@ -143,7 +143,7 @@
144144 $out .= $this->openExtType('Skin extension functions');
145145 $out .= '<tr><td colspan="3">' . $this->listToText( $wgSkinExtensionFunction ) . "</td></tr>\n";
146146 }
147 - $out .= wfCloseElement( 'table' );
 147+ $out .= Xml::closeElement( 'table' );
148148 return $out;
149149 }
150150
@@ -187,7 +187,7 @@
188188 ksort( $myWgHooks );
189189
190190 $ret = "<h2>Hooks</h2>\n"
191 - . wfOpenElement('table', array('id' => 'sv-hooks') )
 191+ . Xml::openElement('table', array('id' => 'sv-hooks') )
192192 . "<tr><th>Hook name</th><th>Subscribed by</th></tr>\n";
193193
194194 foreach ($myWgHooks as $hook => $hooks)
@@ -205,13 +205,13 @@
206206
207207 if(!$this->firstExtOpened) {
208208 // Insert a spacing line
209 - $out .= '<tr class="sv-space">' . wfElement( 'td', $opt ) . "</tr>\n";
 209+ $out .= '<tr class="sv-space">' . Xml::element( 'td', $opt ) . "</tr>\n";
210210 }
211211 $this->firstExtOpened = false;
212212
213213 if($name) { $opt['id'] = "sv-$name"; }
214214
215 - $out .= "<tr>" . wfElement( 'th', $opt, $text) . "</tr>\n";
 215+ $out .= "<tr>" . Xml::element( 'th', $opt, $text) . "</tr>\n";
216216 return $out;
217217 }
218218

Status & tagging log