r29944 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29943‎ | r29944 | r29945 >
Date:06:26, 19 January 2008
Author:brion
Status:old
Tags:
Comment:
Commit ver of doReplace that *doesn't* cause infinite recursion and stack death
Modified paths:
  • /trunk/phase3/includes/SiteConfiguration.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SiteConfiguration.php
@@ -48,7 +48,7 @@
4949 return str_replace( $from, $to, $in );
5050 } elseif( is_array( $in ) ) {
5151 foreach( $in as $key => $val ) {
52 - $in[$key] = $this->doReplace( $from, $to, $in );
 52+ $in[$key] = $this->doReplace( $from, $to, $val );
5353 }
5454 return $in;
5555 } else {

Status & tagging log