r29942 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29941‎ | r29942 | r29943 >
Date:05:39, 19 January 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 12668) Support for custom iPhone bookmark icon via $wgAppleTouchIcon
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -134,7 +134,9 @@
135135 * (bug 18585) Added a bunch of parameters to the revertpage message
136136 * Support redirects in image namespace
137137 * (bug 10049) Prefix index search and namespaces in Special:Withoutinterwiki
 138+* (bug 12668) Support for custom iPhone bookmark icon via $wgAppleTouchIcon
138139
 140+
139141 === Bug fixes in 1.12 ===
140142
141143 * Subpages are now indexed for searching properly when using PostgreSQL
Index: trunk/phase3/includes/DefaultSettings.php
@@ -157,6 +157,7 @@
158158 $wgHashedUploadDirectory = true;
159159 $wgLogo = false; /// defaults to "{$wgStylePath}/common/images/wiki.png"
160160 $wgFavicon = '/favicon.ico';
 161+$wgAppleTouchIcon = false; /// This one'll actually default to off. For iPhone and iPod Touch web app bookmarks
161162 $wgMathPath = false; /// defaults to "{$wgUploadPath}/math"
162163 $wgMathDirectory = false; /// defaults to "{$wgUploadDirectory}/math"
163164 $wgTmpDirectory = false; /// defaults to "{$wgUploadDirectory}/tmp"
Index: trunk/phase3/includes/Skin.php
@@ -153,13 +153,17 @@
154154 }
155155
156156 function initPage( &$out ) {
157 - global $wgFavicon, $wgScriptPath, $wgSitename, $wgContLang;
 157+ global $wgFavicon, $wgAppleTouchIcon, $wgScriptPath, $wgSitename, $wgContLang;
158158
159159 wfProfileIn( __METHOD__ );
160160
161161 if( false !== $wgFavicon ) {
162162 $out->addLink( array( 'rel' => 'shortcut icon', 'href' => $wgFavicon ) );
163163 }
 164+
 165+ if( false !== $wgAppleTouchIcon ) {
 166+ $out->addLink( array( 'rel' => 'apple-touch-icon', 'href' => $wgAppleTouchIcon ) );
 167+ }
164168
165169 $code = $wgContLang->getCode();
166170 $name = $wgContLang->getLanguageName( $code );

Status & tagging log