r29930 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29929‎ | r29930 | r29931 >
Date:19:14, 18 January 2008
Author:nikerabbit
Status:old
Tags:
Comment:
* Some fixes
Modified paths:
  • /trunk/extensions/Translate/CreateMessageIndex.php (modified) (history)
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/CreateMessageIndex.php
@@ -13,8 +13,11 @@
1414 $messages = $g->getDefinitions();
1515 $id = $g->getId();
1616
17 -
18 - echo "Working with $id\n";
 17+ if ( is_array( $messages ) ) {
 18+ echo "Working with $id\n";
 19+ } else {
 20+ echo "Something wrong with $id... skipping\n";
 21+ }
1922 foreach ( $messages as $key => $data ) {
2023 # Force all keys to lower case, because the case doesn't matter and it is
2124 # easier to do comparing when the case of first letter is unknown, because
Index: trunk/extensions/Translate/MessageGroups.php
@@ -2123,6 +2123,15 @@
21242124 public function setLabel( $label ) {
21252125 $this->label = $label;
21262126 }
 2127+
 2128+ /**
 2129+ * Sets meta status for this group.
 2130+ *
 2131+ * @param $value Boolean value
 2132+ */
 2133+ public function setMeta( $value ) {
 2134+ $this->meta = (bool) $value;
 2135+ }
21272136 }
21282137
21292138 class MessageGroups {

Status & tagging log