r2966 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r2965‎ | r2966 | r2967 >
Date:19:55, 4 April 2004
Author:gabrielwicke
Status:old
Tags:
Comment:
* id="autocomment" -> class="autocomment"
* border="0" -> img { border: none; }
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/stylesheets/cologneblue.css (modified) (history)
  • /trunk/phase3/stylesheets/monobook/main.css (modified) (history)
  • /trunk/phase3/stylesheets/nostalgia.css (modified) (history)
  • /trunk/phase3/stylesheets/wikistandard.css (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -707,7 +707,7 @@
708708 $mp = wfMsg( "mainpage" );
709709 $titleObj = Title::newFromText( $mp );
710710 $s = "<a href=\"" . $titleObj->escapeLocalURL()
711 - . "\"><img{$a} border='0' src=\""
 711+ . "\"><img{$a} src=\""
712712 . $this->getLogo() . "\" alt=\"" . "[{$mp}]\" /></a>";
713713 return $s;
714714 }
@@ -1507,8 +1507,8 @@
15081508 }
15091509 if ( "center" == $align )
15101510 {
1511 - $prefix = "<center>";
1512 - $postfix = "</center>";
 1511+ $prefix = '<span style="text-align: center">';
 1512+ $postfix = '</span>';
15131513 $align = "none";
15141514 }
15151515
@@ -1548,7 +1548,7 @@
15491549 $s = str_replace( "$1", $name, wfMsg("missingimage") );
15501550 } else {
15511551 $s = "\n <a href=\"{$u}\" class='image' title=\"{$alt}\">\n" .
1552 - " <img border=\"0\" src=\"{$url}\" alt=\"{$alt}\" />\n </a>";
 1552+ " <img src=\"{$url}\" alt=\"{$alt}\" />\n </a>";
15531553 }
15541554 if ( "" != $align ) {
15551555 $s = "<div class=\"float{$align}\"><span>{$s}\n</span></div>";
@@ -1694,10 +1694,10 @@
16951695 $s .= str_replace( "$1", $name, wfMsg("missingimage") );
16961696 } else {
16971697 $s .= "\n".' <a href="'.$u.'" class="internal" title="'.$alt.'">'."\n".
1698 - ' <img border="0" src="'.$thumbUrl.'" alt="'.$alt.'" ' .
 1698+ ' <img src="'.$thumbUrl.'" alt="'.$alt.'" ' .
16991699 ' width="'.$boxwidth.'" height="'.$boxheight.'" /></a>' ."\n".
17001700 ' <a href="'.$u.'" class="internal" title="'.$more.'"> ' ."\n".
1701 - ' <img border="0" src="'.$wgUploadPath.'/magnify-clip.png" ' .
 1701+ ' <img src="'.$wgUploadPath.'/magnify-clip.png" ' .
17021702 'width="26" height="24" align="'.$magnifyalign.'" alt="'.$more.'" /> </a>'."\n";
17031703 }
17041704 $s .= ' <p'.$textalign.'>'.$label."</p>\n</div></div>";
@@ -1862,8 +1862,8 @@
18631863 $rcm = "RCM{$this->rcCacheIndex}" ;
18641864 $toggleLink = "javascript:toggleVisibility(\"{$rci}\",\"{$rcm}\",\"{$rcl}\")" ;
18651865 $arrowdir = $wgLang->isRTL() ? "l" : "r";
1866 - $tl = "<span id='{$rcm}'><a href='$toggleLink'><img src='{$wgUploadPath}/Arr_{$arrowdir}.png' width='12' height='12' border='0' /></a></span>" ;
1867 - $tl .= "<span id='{$rcl}' style='display:none'><a href='$toggleLink'><img src='{$wgUploadPath}/Arr_d.png' width='12' height='12' border='0' /></a></span>" ;
 1866+ $tl = "<span id='{$rcm}'><a href='$toggleLink'><img src='{$wgUploadPath}/Arr_{$arrowdir}.png' width='12' height='12' /></a></span>" ;
 1867+ $tl .= "<span id='{$rcl}' style='display:none'><a href='$toggleLink'><img src='{$wgUploadPath}/Arr_d.png' width='12' height='12' /></a></span>" ;
18681868 $r .= $tl ;
18691869
18701870 # Main line
@@ -1905,7 +1905,7 @@
19061906 # Get rc_xxxx variables
19071907 extract( $rcObj->mAttribs );
19081908
1909 - $r .= "<img src='{$wgUploadPath}/Arr_.png' width=12 height=12 border=0 />";
 1909+ $r .= "<img src='{$wgUploadPath}/Arr_.png' width=12 height=12 />";
19101910 $r .= "<tt>&nbsp; &nbsp; &nbsp; &nbsp;" ;
19111911 if ( $rc_new ) $r .= $N ;
19121912 else $r .= "&nbsp;" ;
@@ -2196,7 +2196,7 @@
21972197
21982198 # format text between /* .. */ with autocomment CSS class
21992199 $comment=preg_replace("/\/\*\s*(.*?)\s*\*\//i",
2200 - "<span id=\"autocomment\">$1</span>",$comment);
 2200+ "<span class=\"autocomment\">$1</span>",$comment);
22012201 return $comment;
22022202 }
22032203
Index: trunk/phase3/stylesheets/monobook/main.css
@@ -502,7 +502,7 @@
503503 padding: 0;
504504 }
505505 /* the auto-generated edit comments */
506 -#autocomment { color: gray; }
 506+.autocomment { color: gray; }
507507
508508
509509 /*
Index: trunk/phase3/stylesheets/cologneblue.css
@@ -21,7 +21,7 @@
2222
2323 #footer { padding: 4px; }
2424 #footer form { display: inline; }
25 -#autocomment { color: gray; }
 25+.autocomment { color: gray; }
2626 #sitetitle {
2727 font-family: Times, serif;
2828 color: white;
@@ -91,6 +91,7 @@
9292 a.stub { color:#772233; text-decoration:none; }
9393 h2, h3, h4, h5, h6 { margin-bottom: 0; }
9494 small { font-size: 75%; }
 95+img { border: none; }
9596 #toc { border:1px solid #8888aa; background-color:#f7f8ff;padding:5px;font-size:95%; }
9697
9798
Index: trunk/phase3/stylesheets/nostalgia.css
@@ -13,6 +13,7 @@
1414 a.stub { color:#772233; text-decoration:none; }
1515 h1.pagetitle { padding-top: 0; margin-top: 0; padding-bottom: 0; margin-bottom: 0; }
1616 h2, h3, h4, h5, h6 { margin-bottom: 0; }
 17+img { border: none; }
1718 p.subtitle { padding-top: 0; margin-top: 0; }
1819 #toc { border:1px solid #8888aa; background-color:#f7f8ff;padding:5px;font-size:95%; }
1920
@@ -57,6 +58,9 @@
5859 font-size:smaller;
5960 }
6061
 62+/* automatically generated edit summaries */
 63+.autocomment { color: gray; }
 64+
6165 /* Print-specific things to hide */
6266 .urlexpansion, .printfooter {
6367 display: none;
Index: trunk/phase3/stylesheets/wikistandard.css
@@ -9,7 +9,7 @@
1010 #topbar { padding: 4px;font-size:95%; }
1111
1212 /* automatically generated edit summaries */
13 -#autocomment { color: gray; }
 13+.autocomment { color: gray; }
1414
1515 /* Table of contents */
1616 #toc {
@@ -54,6 +54,7 @@
5555 td { empty-cells:show; }
5656 td.bottom { border-top: 1px solid gray; }
5757 td.top { border-bottom: 1px solid gray; }
 58+img { border: none; }
5859 /* images */
5960 div.floatright { float: right; margin: 0 0 1em 1em; }
6061 div.floatright p { font-style: italic; }

Status & tagging log