r29643 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29642‎ | r29643 | r29644 >
Date:07:50, 12 January 2008
Author:aaron
Status:old
Tags:
Comment:
Cleanup; don't store the HTML
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/SpecialConfirmAccount.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/SpecialConfirmAccount.php
@@ -121,7 +121,7 @@
122122 }
123123
124124 function wfConfirmAccountsNotice( $notice ) {
125 - global $wgConfirmAccountNotice, $wgUser, $wgMemc;
 125+ global $wgConfirmAccountNotice, $wgUser, $wgMemc, $wgOut;
126126
127127 if( !$wgConfirmAccountNotice || !$wgUser->isAllowed('confirmaccount') )
128128 return true;
@@ -137,8 +137,7 @@
138138
139139 if( $count ) {
140140 wfLoadExtensionMessages( 'ConfirmAccount' );
141 - $message = '<div id="mw-confirmaccount-msg" class="mw-confirmaccount-bar">' .
142 - wfMsgExt( 'confirmaccount-newrequests', array('parseinline'), $count ) . '</div>';
 141+ $message = wfMsgExt( 'confirmaccount-newrequests', array('parsemag'), $count );
143142 } else {
144143 $message = '';
145144 }
@@ -146,7 +145,7 @@
147146 # Cache results
148147 $wgMemc->set( $key, $message, 3600*24*7 );
149148
150 - $notice .= $message;
 149+ $notice .= '<div id="mw-confirmaccount-msg" class="mw-confirmaccount-bar">' . $wgOut->parse($message) . '</div>';
151150
152151 return true;
153152 }
Index: trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php
@@ -72,7 +72,8 @@
7373 'requestaccount-loginnotice' => 'To obtain a user account, you must \'\'\'[[Special:RequestAccount|request one]]\'\'\'.',
7474
7575 # Site message for admins
76 - 'confirmaccount-newrequests' => 'There are currently \'\'\'$1\'\'\' open [[Special:ConfirmAccounts|account requests]] pending.',
 76+ 'confirmaccount-newrequests' => 'There {{PLURAL:$1|is|are}} currently \'\'\'$1\'\'\' open
 77+ {{PLURAL:$1|[[Special:ConfirmAccounts|account request]]|[[Special:ConfirmAccounts|account requests]]}} pending.',
7778
7879 # Confirm account page
7980 'confirmaccounts' => 'Confirm account requests',

Status & tagging log