r29553 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29552‎ | r29553 | r29554 >
Date:20:27, 10 January 2008
Author:simetrical
Status:old
Tags:
Comment:
Delay message loading for Special:Cite
Modified paths:
  • /trunk/extensions/Cite/SpecialCite.php (modified) (history)
  • /trunk/extensions/Cite/SpecialCite_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/SpecialCite_body.php
@@ -15,6 +15,7 @@
1616
1717 function execute( $par ) {
1818 global $wgOut, $wgRequest, $wgUseTidy;
 19+ wfLoadExtensionMessages( 'SpecialCite' );
1920
2021 // Having tidy on causes whitespace and <pre> tags to
2122 // be generated around the output of the CiteOutput
Index: trunk/extensions/Cite/SpecialCite.php
@@ -13,7 +13,6 @@
1414 * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
1515 */
1616
17 -$wgExtensionFunctions[] = 'wfSpecialCite';
1817 $wgExtensionCredits['specialpage'][] = array(
1918 'name' => 'Cite',
2019 'version' => '2008-01-09',
@@ -33,11 +32,8 @@
3433 }
3534 extAddSpecialPage( dirname(__FILE__) . '/SpecialCite_body.php', 'Cite', 'SpecialCite' );
3635
37 -function wfSpecialCite() {
38 - wfLoadExtensionMessages( 'SpecialCite' );
39 -}
40 -
4136 function wfSpecialCiteNav( &$skintemplate, &$nav_urls, &$oldid, &$revid ) {
 37+ wfLoadExtensionMessages( 'SpecialCite' );
4238 if ( $skintemplate->mTitle->isContentPage() && $revid !== 0 )
4339 $nav_urls['cite'] = array(
4440 'text' => wfMsg( 'cite_article_link' ),
@@ -48,6 +44,7 @@
4945 }
5046
5147 function wfSpecialCiteToolbox( &$monobook ) {
 48+ wfLoadExtensionMessages( 'SpecialCite' );
5249 if ( isset( $monobook->data['nav_urls']['cite'] ) )
5350 if ( $monobook->data['nav_urls']['cite']['href'] == '' ) {
5451 ?><li id="t-iscite"><?php echo $monobook->msg( 'cite_article_link' ); ?></li><?php

Status & tagging log