r29234 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r29233‎ | r29234 | r29235 >
Date:20:54, 3 January 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 12493) Removed hardcoded MAX_FILE_SIZE from Special:Import upload form
No particular reason to limit this beyond the general server settings.
Seems to have been in there since the first version of the form, but dang if I know why I put it there. :)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialImport.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialImport.php
@@ -95,7 +95,6 @@
9696 <form enctype='multipart/form-data' method='post' action=\"$action\">
9797 <input type='hidden' name='action' value='submit' />
9898 <input type='hidden' name='source' value='upload' />
99 - <input type='hidden' name='MAX_FILE_SIZE' value='2097152' />
10099 <input type='file' name='xmlimport' value='' size='30' />
101100 <input type='submit' value=\"" . wfMsgHtml( "uploadbtn" ) . "\" />
102101 </form>
Index: trunk/phase3/RELEASE-NOTES
@@ -284,6 +284,7 @@
285285 it, all applicable reasons are now shown.
286286 * (bug 11428) Allow $wgScript inside $wgArticlePath when emulating PATH_INFO
287287 Fixes 'root'-style rewrite configurations
 288+* (bug 12493) Removed hardcoded MAX_FILE_SIZE from Special:Import upload form
288289
289290
290291 == Parser changes in 1.12 ==

Status & tagging log