r28806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28805‎ | r28806 | r28807 >
Date:20:01, 23 December 2007
Author:simetrical
Status:old
Tags:
Comment:
Tweak wrong comment from last commit, as VasilievVV points out.
Modified paths:
  • /trunk/phase3/includes/Autopromote.php (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -1199,8 +1199,8 @@
12001200 * array( APCOND_AGE, seconds since registration ), *OR*
12011201 * similar constructs defined by extensions.
12021202 *
1203 - * Note that EMAILCONFIRMED will always be true if $wgEmailAuthentication is
1204 - * off!
 1203+ * If $wgEmailAuthentication is off, APCOND_EMAILCONFIRMED will be true for any
 1204+ * user who has provided an e-mail address.
12051205 */
12061206 $wgAutopromote = array(
12071207 'autoconfirmed' => array( '&',
Index: trunk/phase3/includes/Autopromote.php
@@ -85,8 +85,6 @@
8686 switch( $cond[0] ) {
8787 case APCOND_EMAILCONFIRMED:
8888 if( User::isValidEmailAddr( $user->getEmail() ) ) {
89 - # FIXME: EMAILCONFIRMED is always true if
90 - # wgEmailAuthentication if false, this is confusing.
9189 global $wgEmailAuthentication;
9290 if( $wgEmailAuthentication ) {
9391 return $user->getEmailAuthenticationTimestamp() ? true : false;

Status & tagging log