r28783 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28782‎ | r28783 | r28784 >
Date:19:46, 22 December 2007
Author:nikerabbit
Status:old
Tags:
Comment:
* Convert spaces to underscores instead of breaking mysteriously
* (bug 8066) Spaces can't be entered in special page aliases
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
@@ -2134,6 +2134,13 @@
21352135
21362136 # Replace spaces with underscores in namespace names
21372137 $cache['namespaceNames'] = str_replace( ' ', '_', $cache['namespaceNames'] );
 2138+
 2139+ # And do the same for specialpage aliases. $page is an array.
 2140+ foreach ( $cache['specialPageAliases'] as &$page ) {
 2141+ $page = str_replace( ' ', '_', $page );
 2142+ }
 2143+ # Decouple the reference to prevent accidental damage
 2144+ unset($page);
21382145
21392146 # Save to both caches
21402147 self::$mLocalisationCache[$code] = $cache;
Index: trunk/phase3/RELEASE-NOTES
@@ -262,6 +262,7 @@
263263 * Fix regression -- missing feed links in sidebar on Special:Recentchanges
264264 * (bug 12371) Handle more namespace case variants in namespaceDupes.php
265265 * (bug 12380) Bot-friendly EditPage::spamPage
 266+* (bug 8066) Spaces can't be entered in special page aliases
266267
267268 == Parser changes in 1.12 ==
268269

Status & tagging log