r28533 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28532‎ | r28533 | r28534 >
Date:08:59, 16 December 2007
Author:vasilievvv
Status:old
Tags:
Comment:
* (bug 12321) API list=blocks reveals private data
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryBlocks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryBlocks.php
@@ -112,15 +112,13 @@
113113 $block = array();
114114 if($fld_id)
115115 $block['id'] = $row->ipb_id;
116 - if($fld_user)
 116+ if($fld_user && !$row->ipb_auto)
117117 {
118118 $block['user'] = $row->ipb_address;
119 - $block['userid'] = $row->ipb_user;
120119 }
121120 if($fld_by)
122121 {
123122 $block['by'] = $row->user_name;
124 - $block['byuserid'] = $row->ipb_by;
125123 }
126124 if($fld_timestamp)
127125 $block['timestamp'] = wfTimestamp(TS_ISO_8601, $row->ipb_timestamp);
Index: trunk/phase3/RELEASE-NOTES
@@ -360,6 +360,7 @@
361361 * Standardized limits. Revisions and Deletedrevisions formerly using 200 / 10000,
362362 now 500 / 5000, in line with other modules.
363363 * Added list=allcategories module
 364+* (bug 12321) API list=blocks reveals private data
364365
365366 === Languages updated in 1.12 ===
366367

Status & tagging log