r28517 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28516‎ | r28517 | r28518 >
Date:16:28, 15 December 2007
Author:leon
Status:old
Tags:
Comment:
* (bug 11555) Make editsection links come after section seadlines. This has no visible effect to graphical browsers,
but fixes the issue that headlines look like "[edit] Headline" in text browsers.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/monobook/KHTMLFixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/Opera7Fixes.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/Opera7Fixes.css
@@ -9,3 +9,8 @@
1010 background: url(external.png) center right no-repeat;
1111 padding-right: 13px;
1212 }
 13+/* Edit section links */
 14+.editsection {
 15+ margin-top: 0;
 16+}
 17+
Index: trunk/phase3/skins/monobook/KHTMLFixes.css
@@ -1,3 +1,9 @@
22 /* KHTML fix stylesheet */
33 /* work around the horizontal scrollbars */
44 #column-content { margin-left: 0; }
 5+
 6+/* Edit section links */
 7+.editsection {
 8+ margin-top: 0;
 9+}
 10+
Index: trunk/phase3/skins/common/shared.css
@@ -23,6 +23,7 @@
2424 .editsection {
2525 float: right;
2626 margin-left: 5px;
 27+ margin-top:-1.2em;
2728 }
2829
2930 /**
Index: trunk/phase3/includes/Linker.php
@@ -1225,7 +1225,7 @@
12261226 * @return string HTML headline
12271227 */
12281228 public function makeHeadline( $level, $attribs, $anchor, $text, $link ) {
1229 - return "<a name=\"$anchor\"></a><h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
 1229+ return "<a name=\"$anchor\"></a><h$level$attribs<span class=\"mw-headline\">$text</span>$link </h$level>";
12301230 }
12311231
12321232 /**
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1246,7 +1246,7 @@
12471247 * to ensure that client-side caches don't keep obsolete copies of global
12481248 * styles.
12491249 */
1250 -$wgStyleVersion = '102';
 1250+$wgStyleVersion = '103';
12511251
12521252
12531253 # Server-side caching:

Follow-up revisions

RevisionCommit summaryAuthorDate
r93284Fix Bug 11270 & Bug 11555 : Make editsection link more understandable by posi...diebuche16:43, 27 July 2011

Status & tagging log