r2850 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r2849‎ | r2850 | r2851 >
Date:22:27, 26 March 2004
Author:gabrielwicke
Status:old
Tags:
Comment:
skin names as associative array
Modified paths:
  • /trunk/phase3/includes/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPreferences.php
@@ -303,9 +303,9 @@
304304 # Only count up to count($wgValidSkinNames) rather than
305305 # count($skins), to allow global disabling of experimental
306306 # skins.
307 - for ( $i = 0; $i < count( $wgValidSkinNames ); ++$i ) {
 307+ foreach ($wgValidSkinNames as $i => $skinname ) {
308308 if ( $i == $wpSkin ) {
309 - $checked = " checked";
 309+ $checked = ' checked="checked"';
310310 } else {
311311 $checked = "";
312312 }

Status & tagging log