r28261 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28260‎ | r28261 | r28262 >
Date:02:21, 8 December 2007
Author:david
Status:old
Tags:
Comment:
Different design for editedness marker.
Modified paths:
  • /trunk/extensions/LiquidThreads/Lqt.i18n.php (modified) (history)
  • /trunk/extensions/LiquidThreads/LqtBaseView.php (modified) (history)
  • /trunk/extensions/LiquidThreads/lqt.css (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/Lqt.i18n.php
@@ -20,8 +20,7 @@
2121 'lqt_add_header' => 'Add header',
2222 'lqt_new_thread' => 'Start a new discussion',
2323 'lqt_in_response_to' => 'In reply to $1 by $2, above:',
24 - 'lqt_edited_notice_author' => "This message was re-edited by the original author.",
25 - 'lqt_edited_notice_others' => "This message was edited by someone other than the author.",
 24+ 'lqt_edited_notice' => 'Edited',
2625 'lqt_move_placeholder' => "''Placeholder left when the thread was moved to another page.''",
2726 'lqt_reply' => 'Reply',
2827 'lqt_delete' => 'Delete',
Index: trunk/extensions/LiquidThreads/lqt.css
@@ -235,9 +235,16 @@
236236
237237
238238 .lqt_edited_notice {
239 - color: #777;
240 - font-size: smaller;
 239+/* font-size: smaller;
 240+ margin-top: -0.5em;
 241+ padding-top: 0;*/
241242 }
 243+.lqt_edited_notice_author {
 244+/* color: #c2cb9a; */
 245+}
 246+.lqt_edited_notice_others {
 247+/* color: #bb84b4; */
 248+}
242249
243250
244251 .lqt_header {
Index: trunk/extensions/LiquidThreads/LqtBaseView.php
@@ -718,10 +718,19 @@
719719 $this->output->addHTML(<<<HTML
720720 <ul class="lqt_footer">
721721 <li class="lqt_author_sig lqt_post_color_{$color_number}">$sig</li>
722 -<li>$timestamp</li>
723722 HTML
724723 );
 724+
 725+ if( $thread->editedness() == Threads::EDITED_BY_AUTHOR ||
 726+ $thread->editedness() == Threads::EDITED_BY_OTHERS ) {
 727+ $editedness_url = $this->permalinkUrlWithQuery($thread, 'action=history');
 728+ $editedness_color_number = $thread->editedness() == Threads::EDITED_BY_AUTHOR ?
 729+ $color_number : ($color_number == self::number_of_user_colors ? 1 : $color_number + 1);
 730+ $this->output->addHTML("<li class=\"lqt_edited_notice lqt_post_color_{$editedness_color_number}\">".'<a href="'.$editedness_url.'">'.wfMsg('lqt_edited_notice').'</a>'.'</li>');
 731+ }
725732
 733+ $this->output->addHTML("<li>$timestamp</li>");
 734+
726735 $this->output->addHTML($this->listItemsForCommands($this->threadFooterCommands($thread)));
727736
728737 $this->output->addHTML('</ul>');
@@ -875,16 +884,12 @@
876885 ) .'</p>');
877886 }
878887
 888+
879889
880 - if( $thread->editedness() == Threads::EDITED_BY_AUTHOR ) {
881 - $this->output->addHTML('<div class="lqt_edited_notice">'.wfMsg('lqt_edited_notice_author').'</div>');
882 - } else if($thread->editedness() == Threads::EDITED_BY_OTHERS ) {
883 - $this->output->addHTML('<div class="lqt_edited_notice">'.wfMsg('lqt_edited_notice_others').'</div>');
884 - }
885 -
886890 $this->openDiv('lqt_thread', "lqt_thread_id_{$thread->id()}");
887891
888892 $this->showRootPost( $thread );
 893+
889894 if( $thread->hasSubthreads() ) $this->indent($thread);
890895 foreach( $thread->subthreads() as $st ) {
891896 $this->showThread($st);

Status & tagging log