r28161 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28160‎ | r28161 | r28162 >
Date:22:52, 4 December 2007
Author:amidaniel
Status:old
Tags:
Comment:
Rmv "for" property of labels on Gadgets preferences page. Causes some annoying behavior when the label is a link to another page.
Modified paths:
  • /trunk/extensions/Gadgets/Gadgets.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Gadgets/Gadgets.php
@@ -166,7 +166,7 @@
167167 $disabled = '';
168168
169169 $out->addHtml( "<div class='toggle'><input type='checkbox' value='1' id=\"$tname\" name=\"wpOp$tname\"$checked$disabled />" .
170 - " <span class='toggletext'><label for=\"$tname\">$ttext</label></span></div>\n" );
 170+ " <span class='toggletext'><label>$ttext</label></span></div>\n" );
171171 }
172172 }
173173

Status & tagging log