r28153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r28152‎ | r28153 | r28154 >
Date:20:47, 4 December 2007
Author:brion
Status:old
Tags:
Comment:
Revert r28136; overlong title prefix obscures page title in tabs, window lists, etc
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DifferenceEngine.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -639,7 +639,7 @@
640640 ),
641641 'diffs' => array(
642642 'history-title',
643 - 'difference-title',
 643+ 'difference',
644644 'lineno',
645645 'compareselectedversions',
646646 'editundo',
@@ -798,7 +798,6 @@
799799 'rc_categories_any',
800800 'rc-change-size',
801801 'newsectionsummary',
802 - 'difference',
803802 ),
804803 'recentchangeslinked' => array(
805804 'recentchangeslinked',
Index: trunk/phase3/includes/DifferenceEngine.php
@@ -72,10 +72,6 @@
7373 $this->mRefreshCache = $refreshCache;
7474 }
7575
76 - /**
77 - * Show difference between revisions
78 - * @param $diffOnly bool show the difference only, no preview
79 - */
8076 function showDiffPage( $diffOnly = false ) {
8177 global $wgUser, $wgOut, $wgUseExternalEditor, $wgUseRCPatrol;
8278 $fname = 'DifferenceEngine::showDiffPage';
@@ -130,7 +126,6 @@
131127 # a diff between a version V and its previous version V' AND the version V
132128 # is the first version of that article. In that case, V' does not exist.
133129 if ( $this->mOldid === false ) {
134 - $wgOut->setPageTitle( wfMsg( 'difference-title', $this->mTitle->getPrefixedText() ) );
135130 $this->showFirstRevision();
136131 $this->renderNewRevision(); // should we respect $diffOnly here or not?
137132 wfProfileOut( $fname );
@@ -142,10 +137,11 @@
143138 $oldTitle = $this->mOldPage->getPrefixedText();
144139 $newTitle = $this->mNewPage->getPrefixedText();
145140 if( $oldTitle == $newTitle ) {
146 - $wgOut->setPageTitle( wfMsg( 'difference-title', $newTitle ) );
 141+ $wgOut->setPageTitle( $newTitle );
147142 } else {
148 - $wgOut->setPageTitle( wfMsg( 'difference-title', $oldTitle . ', ' . $newTitle ) );
 143+ $wgOut->setPageTitle( $oldTitle . ', ' . $newTitle );
149144 }
 145+ $wgOut->setSubtitle( wfMsg( 'difference' ) );
150146 $wgOut->setRobotpolicy( 'noindex,nofollow' );
151147
152148 if ( !( $this->mOldPage->userCanRead() && $this->mNewPage->userCanRead() ) ) {
@@ -370,6 +366,7 @@
371367
372368 $wgOut->addHTML( $header );
373369
 370+ $wgOut->setSubtitle( wfMsg( 'difference' ) );
374371 $wgOut->setRobotpolicy( 'noindex,nofollow' );
375372
376373 wfProfileOut( $fname );
@@ -2015,3 +2012,6 @@
20162013 wfProfileOut( $fname );
20172014 }
20182015 }
 2016+
 2017+
 2018+
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1215,7 +1215,7 @@
12161216
12171217 # Diffs
12181218 'history-title' => 'Revision history of "$1"',
1219 -'difference-title' => 'Difference between revisions of "$1"',
 1219+'difference' => '(Difference between revisions)',
12201220 'lineno' => 'Line $1:',
12211221 'compareselectedversions' => 'Compare selected versions',
12221222 'editundo' => 'undo',
@@ -1389,7 +1389,6 @@
13901390 'rc_categories_any' => 'Any',
13911391 'rc-change-size' => '$1', # only translate this message to other languages if you have to change it
13921392 'newsectionsummary' => '/* $1 */ new section',
1393 -'difference' => '(Difference between revisions)',
13941393
13951394 # Recent changes linked
13961395 'recentchangeslinked' => 'Related changes',
Index: trunk/phase3/languages/messages/MessagesDe.php
@@ -876,7 +876,7 @@
877877
878878 # Diffs
879879 'history-title' => 'Versionsgeschichte von „$1“',
880 -'difference-title' => 'Versionsunterschied: „$1“',
 880+'difference' => '(Unterschied zwischen Versionen)',
881881 'lineno' => 'Zeile $1:',
882882 'compareselectedversions' => 'Gewählte Versionen vergleichen',
883883 'editundo' => 'rückgängig',
@@ -1035,7 +1035,6 @@
10361036 'rc_categories_any' => 'Alle',
10371037 'rc-change-size' => '$1 {{PLURAL:$1|Byte|Bytes}}',
10381038 'newsectionsummary' => 'Neuer Abschnitt /* $1 */',
1039 -'difference' => '(Unterschied zwischen Versionen)',
10401039
10411040 # Recent changes linked
10421041 'recentchangeslinked' => 'Änderungen an verlinkten Seiten',
Index: trunk/phase3/RELEASE-NOTES
@@ -86,7 +86,6 @@
8787 * Show a warning message when creating/editing a user (talk) page but the user
8888 does not exists
8989 * (bug 8396) Ignore out-of-date serialised message caches
90 -* Add descriptive <title> to revision difference page
9190 * (bug 12195) Undeleting pages now requires 'undelete' permission
9291
9392 === Bug fixes in 1.12 ===

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r28136* Add descriptive <title> to revision difference page...raymond10:56, 4 December 2007

Status & tagging log