r27757 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r27756‎ | r27757 | r27758 >
Date:15:43, 22 November 2007
Author:nikerabbit
Status:old
Tags:
Comment:
* The number of watching users in watchlists was always reported as 1
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialWatchlist.php
@@ -294,7 +294,7 @@
295295 }
296296
297297 if ($wgRCShowWatchingUsers && $wgUser->getOption( 'shownumberswatching' )) {
298 - $sql3 = "SELECT COUNT(*) AS n FROM $watchlist WHERE wl_title='" .$dbr->strencode($obj->page_title). "' AND wl_namespace='{$obj->page_namespace}'" ;
 298+ $sql3 = "SELECT COUNT(*) AS n FROM $watchlist WHERE wl_title='" .$dbr->strencode($obj->rc_title). "' AND wl_namespace='{$obj->rc_namespace}'" ;
299299 $res3 = $dbr->query( $sql3, $fname );
300300 $x = $dbr->fetchObject( $res3 );
301301 $rc->numberofWatchingusers = $x->n;
Index: trunk/phase3/RELEASE-NOTES
@@ -191,6 +191,7 @@
192192 * Support {{PLURAL}} for import log
193193 * Make sure that the correct log entries are shown on Special:Userrights even
194194 for users with special characters in their names
 195+* The number of watching users in watchlists was always reported as 1
195196
196197 == Parser changes in 1.12 ==
197198

Status & tagging log