r27035 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r27034‎ | r27035 | r27036 >
Date:01:47, 30 October 2007
Author:aaron
Status:old
Tags:
Comment:
*Rename revision rows all at once. This avoid issues with revision being deleted while renaming is slowly taking place (the deleted edits would be stuck with the old name). Using the Jobqueue for renames still involves a good deal of data going into the job table, not sure if it's worth it anyway.
Modified paths:
  • /trunk/extensions/Renameuser/SpecialRenameuser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Renameuser/SpecialRenameuser_body.php
——@@ -302,12 +302,13 @@
303303 $this->tables = array(
304304 'image' => 'img_user_text',
305305 'oldimage' => 'oi_user_text',
306 - 'archive' => 'ar_user_text'
 306+ 'archive' => 'ar_user_text',
 307+ 'revision' => 'rev_user_text'
307308 );
308309 $this->tablesJob = array();
309310 // See if this is for large tables on large, busy, wikis
310311 if( function_exists('wfQueriesMustScale') && wfQueriesMustScale() ) {
311 - $this->tablesJob['revision'] = array('rev_user_text','rev_id');
 312+ #$this->tablesJob['revision'] = array('rev_user_text','rev_id');
312313 $this->tablesJob['recentchanges'] = array('rc_user_text','rc_id');
313314 } else {
314315 $this->tables['revision'] = 'rev_user_text';

Status & tagging log