r26940 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26939‎ | r26940 | r26941 >
Date:06:07, 25 October 2007
Author:kim
Status:old
Tags:
Comment:
small changes
Modified paths:
  • /trunk/extensions/Wikidata/Database+scripts/Convenience/Create+wikidata.php (modified) (history)
  • /trunk/extensions/Wikidata/Database+scripts/Convenience/wikidataSourceTables.sql (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/WikiDataAPI.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/Database scripts/Convenience/Create wikidata.php
@@ -14,12 +14,13 @@
1515 $currentdir = dirname( __FILE__ );
1616 chdir( $IP );
1717
18 -ini_set( 'include_path', ".$sepIP$sep$IP/extensions/Wikidata/OmegaWiki$sep$IP/includes$sep$IP/languages$sep$IP/maintenance" );
 18+ini_set( 'include_path', ".$sep$IP/extensions/Wikidata/OmegaWiki$sep$IP/includes$sep$IP/languages$sep$IP/maintenance" );
1919
2020 require_once( "Defines.php");
2121 require_once( "ProfilerStub.php");
2222 require_once( "LocalSettings.php");
2323 require_once( "Setup.php");
 24+ini_set( 'include_path', ".$sep$IP/extensions/Wikidata/OmegaWiki$sep$IP/includes$sep$IP/languages$sep$IP/maintenance" );
2425 require_once( "Attribute.php" );
2526 require_once( "Transaction.php");
2627 require_once( "WikiDataBootstrappedMeanings.php");
@@ -249,4 +250,4 @@
250251 $wdDatabase->close();
251252
252253
253 -?>
\ No newline at end of file
 254+?>
Index: trunk/extensions/Wikidata/Database scripts/Convenience/wikidataSourceTables.sql
@@ -56,6 +56,7 @@
5757 ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci;
5858
5959 CREATE TABLE /*$wgWDprefix*/collection_contents (
 60+`object_id` int(11) default NULL,
6061 `collection_id` int(10) NOT NULL default '0',
6162 `member_mid` int(10) NOT NULL default '0',
6263 `internal_member_id` varchar(255) default NULL,
Index: trunk/extensions/Wikidata/OmegaWiki/WikiDataAPI.php
@@ -1256,7 +1256,7 @@
12571257 member_mid=$dm_id,
12581258 add_transaction_id=$add_transaction_id
12591259 ";
1260 - $dbr->query($sql);
 1260+ $result=$dbr->query($sql);
12611261 }
12621262
12631263 /**read a ConceptMapping from the database

Status & tagging log