r26435 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26434‎ | r26435 | r26436 >
Date:12:04, 5 October 2007
Author:mkroetzsch
Status:old
Tags:
Comment:
Fixed wrong fname for DB-query
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore.php
@@ -1277,7 +1277,6 @@
12781278 $db->query("INSERT INTO $tablename (title) VALUES " . $sqlvalues, 'SMW::getCategoryTable');
12791279 $db->query("INSERT INTO $tmpnew (title) VALUES " . $sqlvalues, 'SMW::getCategoryTable');
12801280
1281 - /// TODO: avoid duplicate results?
12821281 for ($i=0; $i<$smwgQSubcategoryDepth; $i++) {
12831282 $db->query("INSERT INTO $tmpres (title) SELECT $pagetable.page_title
12841283 FROM $cltable,$pagetable,$tmpnew WHERE
@@ -1339,7 +1338,6 @@
13401339 $db->query("INSERT INTO $tablename (title) VALUES (" . $db->addQuotes($propname) . ')', 'SMW::getPropertyTable');
13411340 $db->query("INSERT INTO $tmpnew (title) VALUES (" . $db->addQuotes($propname) . ')', 'SMW::getPropertyTable');
13421341
1343 - /// TODO: avoid duplicate results?
13441342 for ($i=0; $i<$smwgQSubpropertyDepth; $i++) {
13451343 $db->query("INSERT INTO $tmpres (title) SELECT $sptable.subject_title
13461344 FROM $sptable,$tmpnew WHERE
@@ -1348,7 +1346,7 @@
13491347 continue;
13501348 }
13511349 $db->query("INSERT IGNORE INTO $tablename (title) SELECT $tmpres.title
1352 - FROM $tmpres", 'SMW::getCategoryTable');
 1350+ FROM $tmpres", 'SMW::getPropertyTable');
13531351 if ($db->affectedRows() == 0) { // no change, exit loop
13541352 continue;
13551353 }

Status & tagging log